Subject: Re: [PATCH net-next v3] Add support of Cavium Liquidio ethernet adapters

From: Lino Sanfilippo <[email-masked]>
Date: Fri, 19 Dec 2014 23:51:15 +0100

On 19.12.2014 04:25, Raghu Vatsavayi wrote:

> static int
> +oct_cfg_rx_intrcnt(struct lio *lio, struct ethtool_coalesce *intr_coal)
> +{

> +	}
> +
> +	spin_lock_irqsave(&cn6xxx->lock_for_droq_int_enb_reg, flags);
> +	octeon_write_csr(oct, OCT_SLI_REGNAME(oct, PKT_CNT_INT_ENB), intr);
> +	spin_unlock_irqrestore(&cn6xxx->lock_for_droq_int_enb_reg, flags);
> +
> +	return 0;

What is the reason that this is locked? If it really has to be
synchronized then there should AFAIK at least be an mmiowb() to make
sure that the write does not leak out of the lock...

Regards,
Lino