Subject: Re: [PATCH 2/3] net/fsl: remove irq assignment from xgmac_mdio

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 23 Dec 2014 17:11:35 +0300

Hello.

On 12/23/2014 12:46 PM, [email-masked] wrote:

> From: Shaohui Xie <[email-masked]>

> Which is wrong and not used, so no extra space needed by
> mdio_alloc_size(), change the parameter accordingly.

> Signed-off-by: Shaohui Xie <[email-masked]>
> ---
>   drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
> index 90adba1..72e0b85 100644
> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
> @@ -187,14 +187,13 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
>   		return ret;
>   	}
>
> -	bus = mdiobus_alloc_size(PHY_MAX_ADDR * sizeof(int));
> +	bus = mdiobus_alloc_size(0);

    It's now equivalent to a mere mdiobus_alloc().

[...]

WBR, Sergei