From: Larry Finger <Larry.Finger@lwfinger•net>
To: gregkh@linuxfoundation•org
Cc: devel@driverdev•osuosl.org, netdev@vger•kernel.org
Subject: Re: [PATCH] staging: r8188eu: Fix memory leak in firmware loading
Date: Fri, 02 Jan 2015 23:57:03 -0600 [thread overview]
Message-ID: <54A784AF.1050604@lwfinger.net> (raw)
In-Reply-To: <1420222628-4955-1-git-send-email-Larry.Finger@lwfinger.net>
On 01/02/2015 12:17 PM, Larry Finger wrote:
> The driver allocates memory to store the firmware image; however, that
> memory is never released. The kmemleak facility was used to find this
> error.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger•net>
> ---
> drivers/staging/rtl8188eu/hal/fw.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c
> index 3b28754..a5b7fc4 100644
> --- a/drivers/staging/rtl8188eu/hal/fw.c
> +++ b/drivers/staging/rtl8188eu/hal/fw.c
> @@ -231,6 +231,7 @@ int rtl88eu_download_fw(struct adapter *adapt)
> _rtl88e_enable_fw_download(adapt, false);
>
> err = _rtl88e_fw_free_to_go(adapt);
> + kfree(pfwdata);
>
> return err;
> }
Greg,
Please drop this patch. Unfortunately, further testing showed that the kfree()
call is in the wrong place. I will send V2 shortly.
Thanks,
Larry
prev parent reply other threads:[~2015-01-03 5:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 18:17 [PATCH] staging: r8188eu: Fix memory leak in firmware loading Larry Finger
2015-01-03 5:57 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A784AF.1050604@lwfinger.net \
--to=larry.finger@lwfinger$(echo .)net \
--cc=devel@driverdev$(echo .)osuosl.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox