From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public•gmane.org>
To: Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public•gmane.org>,
kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH 02/11] rtlwifi: rtl8723be: Improve modinfo output
Date: Tue, 06 Jan 2015 09:59:06 -0600 [thread overview]
Message-ID: <54AC064A.6090505@lwfinger.net> (raw)
In-Reply-To: <54A6E50E.8070205-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
On 01/02/2015 12:35 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 1/2/2015 7:58 PM, Larry Finger wrote:
>
>> The description of the power-save variables for this driver is not as
>> clear as for the others. The wording is changed to match the others.
>
>> Signed-off-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public•gmane.org>
>> ---
>> drivers/net/wireless/rtlwifi/rtl8723be/sw.c | 11 ++++++-----
>> 1 file changed, 6 insertions(+), 5 deletions(-)
>
>> diff --git a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
>> b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
>> index 223eb42..52a6d90 100644
>> --- a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
>> +++ b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
>> @@ -387,12 +387,13 @@ module_param_named(swlps,
>> rtl8723be_mod_params.swctrl_lps, bool, 0444);
>> module_param_named(fwlps, rtl8723be_mod_params.fwctrl_lps, bool, 0444);
>> module_param_named(disable_watchdog, rtl8723be_mod_params.disable_watchdog,
>> bool, 0444);
>> -MODULE_PARM_DESC(swenc, "using hardware crypto (default 0 [hardware])\n");
>> -MODULE_PARM_DESC(ips, "using no link power save (default 1 is open)\n");
>> -MODULE_PARM_DESC(fwlps, "using linked fw control power save (default 1 is
>> open)\n");
>> -MODULE_PARM_DESC(msi, "Set to 1 to use MSI interrupts mode (default 0)\n");
>
> You are completely removing this description. Is it intentional?
>
>> +MODULE_PARM_DESC(swenc, "Set to 1 for software crypto (default 0)\n");
>> +MODULE_PARM_DESC(ips, "Set to 0 to not use link power save (default 1)\n");
>> +MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 0)\n");
>> +MODULE_PARM_DESC(fwlps, "Set to 1 to use FW control power save (default 1)\n");
>> MODULE_PARM_DESC(debug, "Set debug level (0-5) (default 0)");
>> -MODULE_PARM_DESC(disable_watchdog, "Set to 1 to disable the watchdog (default
>> 0)\n");
>> +MODULE_PARM_DESC(disable_watchdog,
>> + "Set to 1 to disable the watchdog (default 0)\n");
>
> WBR, Sergei
Good catch. Fixed in V2.
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-06 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 16:58 [PATCH 00/11] rtlwifi: A set of patches that simplify the drivers Larry Finger
2015-01-02 16:58 ` [PATCH 01/11] rtlwifi: Unify variable naming for all drivers Larry Finger
2015-01-02 16:58 ` [PATCH 02/11] rtlwifi: rtl8723be: Improve modinfo output Larry Finger
[not found] ` <1420217908-1382-3-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2015-01-02 18:35 ` Sergei Shtylyov
[not found] ` <54A6E50E.8070205-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-01-06 15:59 ` Larry Finger [this message]
2015-01-02 16:58 ` [PATCH 03/11] rtlwifi: Create new routine to initialize the DM tables Larry Finger
2015-01-02 16:58 ` [PATCH 05/11] rtlwifi: rtl8192c-common: Convert driver to use common DM table initialization Larry Finger
2015-01-02 16:58 ` [PATCH 06/11] rtlwifi: rtl8192de: " Larry Finger
2015-01-02 16:58 ` [PATCH 07/11] rtlwifi: rtl8192ee: " Larry Finger
2015-01-02 16:58 ` [PATCH 08/11] rtlwifi: rtl8723ae: " Larry Finger
2015-01-02 16:58 ` [PATCH 09/11] rtlwifi: rtl8723be: " Larry Finger
[not found] ` <1420217908-1382-1-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2015-01-02 16:58 ` [PATCH 04/11] rtlwifi: rtl8188ee: Convert driver to use the common DM table init routine Larry Finger
2015-01-02 16:58 ` [PATCH 10/11] rtlwifi: rtl8821ae: Convert driver to use common DM table initialization Larry Finger
2015-01-02 16:58 ` [PATCH 11/11] rtlwifi: Move macro definitions to core Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AC064A.6090505@lwfinger.net \
--to=larry.finger-tq5ms3gmjblk1umjsbkqmq@public$(echo .)gmane.org \
--cc=kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox