Subject: Re: [PATCH iproute2 -next v2] ip: route: add congestion control metric

From: Daniel Borkmann <[email-masked]>
Date: Thu, 08 Jan 2015 00:37:48 +0100

On 01/08/2015 12:06 AM, Stephen Hemminger wrote:
> On Wed,  7 Jan 2015 12:28:18 +0100
> Daniel Borkmann <[email-masked]> wrote:
>
>> +			if (i != RTAX_CC_ALGO)
>> +				val = *(unsigned *)RTA_DATA(mxrta[i]);
>
> Please use rta_getattr_u32 here.
>
> Yes, I know you copied old code, but the old code predated the helper
> functions.

No problem, that looks better indeed. Will add it.

Btw, while we're on the topic, we ignore errors for all rta_addattr*()
functions f.e. in iproute_modify(). I think at least we should undo the
mxlock in case of an error (or bail out entirely as a different option).

Thanks,
Daniel