From: Tom Lendacky <thomas.lendacky@amd•com>
To: Tony Lindgren <tony@atomide•com>, David Miller <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>, <linux-omap@vger•kernel.org>,
Brian Hutchinson <b.hutchman@gmail•com>,
Felipe Balbi <balbi@ti•com>
Subject: Re: [PATCH 3/6] net: davinci_emac: Free clock after checking the frequency
Date: Tue, 13 Jan 2015 13:48:24 -0600 [thread overview]
Message-ID: <54B57688.6000908@amd.com> (raw)
In-Reply-To: <1421177368-19756-4-git-send-email-tony@atomide.com>
On 01/13/2015 01:29 PM, Tony Lindgren wrote:
> We only use clk_get() to get the frequency, the rest is done by
> the runtime PM calls. Let's free the clock too.
>
> Cc: Brian Hutchinson <b.hutchman@gmail•com>
> Cc: Felipe Balbi <balbi@ti•com>
> Signed-off-by: Tony Lindgren <tony@atomide•com>
> ---
> drivers/net/ethernet/ti/davinci_emac.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
> index deb43b3..e9efc74 100644
> --- a/drivers/net/ethernet/ti/davinci_emac.c
> +++ b/drivers/net/ethernet/ti/davinci_emac.c
> @@ -1881,6 +1881,7 @@ static int davinci_emac_probe(struct platform_device *pdev)
> return -EBUSY;
> }
> emac_bus_frequency = clk_get_rate(emac_clk);
> + clk_put(emac_clk);
The devm_clk_get call is used to get the clock so either a devm_clk_put
needs to be used here or just let the devm_ call do its thing and
automatically do the put when the module is unloaded.
Thanks,
Tom
>
> /* TODO: Probe PHY here if possible */
>
>
next prev parent reply other threads:[~2015-01-13 19:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 19:29 [PATCH 0/6] Fixes for davinci_emac Tony Lindgren
2015-01-13 19:29 ` [PATCH 1/6] net: davinci_emac: Fix hangs with interrupts Tony Lindgren
2015-01-13 19:36 ` Felipe Balbi
2015-01-13 19:45 ` Tony Lindgren
2015-01-13 19:29 ` [PATCH 2/6] net: davinci_emac: Fix runtime pm calls for davinci_emac Tony Lindgren
2015-01-13 19:51 ` Felipe Balbi
2015-01-13 20:54 ` Tony Lindgren
2015-01-13 21:03 ` Felipe Balbi
2015-01-13 23:42 ` Mark A. Greer
2015-01-13 19:29 ` [PATCH 3/6] net: davinci_emac: Free clock after checking the frequency Tony Lindgren
2015-01-13 19:48 ` Tom Lendacky [this message]
2015-01-13 19:50 ` Felipe Balbi
2015-01-13 20:15 ` Tony Lindgren
2015-01-13 19:54 ` Tony Lindgren
2015-01-13 21:05 ` David Miller
2015-01-14 19:10 ` Tony Lindgren
2015-01-13 19:29 ` [PATCH 4/6] net: davinci_emac: Fix incomplete code for getting the phy from device tree Tony Lindgren
2015-01-13 19:29 ` [PATCH 5/6] net: davinci_emac: Fix ioremap for devices with MDIO within the EMAC address space Tony Lindgren
2015-01-13 19:54 ` Felipe Balbi
2015-01-13 19:59 ` Tony Lindgren
2015-01-13 20:21 ` Felipe Balbi
2015-01-13 19:29 ` [PATCH 6/6] net: davinci_emac: Add support for emac on dm816x Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2015-01-15 22:45 [PATCHv2 0/6] Fixes for davinci_emac Tony Lindgren
2015-01-15 22:45 ` [PATCH 3/6] net: davinci_emac: Free clock after checking the frequency Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B57688.6000908@amd.com \
--to=thomas.lendacky@amd$(echo .)com \
--cc=b.hutchman@gmail$(echo .)com \
--cc=balbi@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tony@atomide$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox