Subject: Re: [PATCH net-next v12 3/3] net: hisilicon: new hip04 ethernet driver

From: Ding Tianhong <[email-masked]>
Date: Wed, 14 Jan 2015 12:22:20 +0800

On 2015/1/14 12:06, David Miller wrote:
> From: Ding Tianhong <[email-masked]>
> Date: Tue, 13 Jan 2015 17:11:30 +0800
> 
>> +static int hip04_alloc_ring(struct net_device *ndev, struct device *d)
>> +{
>> +	struct hip04_priv *priv = netdev_priv(ndev);
>> +	int i;
>> +
>> +	priv->tx_desc = dma_alloc_coherent(d,
>> +			TX_DESC_NUM * sizeof(struct tx_desc),
>> +			&priv->tx_desc_dma, GFP_KERNEL);
> 
> When a function call spans multiple lines, the arguments on the
> second and subsequent lines should start at the first column
> after the openning parenthesis of the function call.
> 
> If you are only using TAB characters, your indentation is likely
> to be incorrect.
> 

Sorry for the mistake.

>> +	/*
>> +	 * BQL will try to keep the TX queue as short as possible, but it can't
>> +	 * be faster than tx_coalesce_usecs, so we need a fast timeout here,
>> +	 * but also long enough to gather up enough frames to ensure we don't
>> +	 * get more interrupts than necessary.
>> +	 * 200us is enough for 16 frames of 1500 bytes at gigabit ethernet rate
>> +	 */
> 
> Comments in the networking should be:
> 
> 	/* Formatted
> 	 * like this.
> 	 */
> 

yes.
>> +	priv->phy_node = of_parse_phandle(node, "phy-handle", 0);
>> +	if (priv->phy_node) {
>> +		priv->phy = of_phy_connect(ndev, priv->phy_node,
>> +			&hip04_adjust_link, 0, priv->phy_mode);
> 
> Please align the arguments to this function call correctly, as
> per above.
> 
Ok, I will check them again.

Ding

> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> .
>