From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Cong Wang <cwang@twopensource•com>
Cc: "David Miller" <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>,
nbd@openwrt•org, pablo@netfilter•org,
"Florian Westphal" <fw@strlen•de>,
"Jiří Pírko" <jiri@resnulli•us>
Subject: Re: [net-next PATCH v2 1/1] net: sched: Introduce connmark action
Date: Sun, 18 Jan 2015 16:22:28 -0500 [thread overview]
Message-ID: <54BC2414.2010100@mojatatu.com> (raw)
In-Reply-To: <CAHA+R7Muz_d47NX01tKO7v7V7m=5mKf+BPP1jo9dEH==8R6bgw@mail.gmail.com>
On 01/18/15 16:00, Cong Wang wrote:
> On Sun, Jan 18, 2015 at 12:00 PM, Jamal Hadi Salim <jhs@mojatatu•com> wrote:
>> +
>> +MODULE_AUTHOR("Felix Fietkau <nbd@openwrt•org>");
>> +MODULE_DESCRIPTION("Connection tracking mark restoring");
>> +MODULE_LICENSE("GPL");
>
>
> Please move these to the bottom.
>
Done.
>> +
>> +static int __init connmark_init_module(void)
>> +{
>> + int ret;
>> +
>> + ret = tcf_hashinfo_init(&connmark_hash_info, CONNMARK_TAB_MASK);
>> + if (ret)
>> + return ret;
>> +
>
> Is this against latest net-next? We don't need to init the hashinfo anymore,
> tcf_register_action() already does that.
>
The code itself has been living outside the tree - so i am just doing
only necessary transforms. The above was needed because the action
was maintaining its own hash.
I will convert to the new mode.
>> + return tcf_register_action(&act_connmark_ops, CONNMARK_TAB_MASK);
>> +}
>> +
>> +static void __exit connmark_cleanup_module(void)
>> +{
>> + tcf_unregister_action(&act_connmark_ops);
>> +}
>> +
>
> Even if we really needed, you forgot to call tcf_hashinfo_destroy()?
>
Didnt follow - why do you need tcf_hashinfo_destroy()?
Will send v3 shortly
cheers,
jamal
> Thanks.
>
prev parent reply other threads:[~2015-01-18 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 20:00 [net-next PATCH v2 1/1] net: sched: Introduce connmark action Jamal Hadi Salim
2015-01-18 21:00 ` Cong Wang
2015-01-18 21:22 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BC2414.2010100@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=cwang@twopensource$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fw@strlen$(echo .)de \
--cc=jiri@resnulli$(echo .)us \
--cc=nbd@openwrt$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox