From: Jonathan Toppins <jtoppins@cumulusnetworks•com>
To: Nikolay Aleksandrov <nikolay@redhat•com>, netdev@vger•kernel.org
Cc: Veaceslav Falico <vfalico@gmail•com>,
Jay Vosburgh <j.vosburgh@gmail•com>,
Andy Gospodarek <andy@greyhouse•net>
Subject: Re: [PATCH net-next 0/5] bonding: various 802.3ad fixes
Date: Mon, 19 Jan 2015 15:39:00 -0500 [thread overview]
Message-ID: <54BD6B64.2010505@cumulusnetworks.com> (raw)
In-Reply-To: <54BD5B0B.5030507@redhat.com>
On 1/19/15 2:29 PM, Nikolay Aleksandrov wrote:
> On 01/16/2015 04:57 PM, Jonathan Toppins wrote:
>> This patch series is a forward porting of patches we (Cumulus) are shipping
>> in our 3.2 series kernels. These fixes attempt to make 802.3ad bonding mode
>> more predictable in certian state machine transtions in addition to enhancing
>> 802.3ad bond carrier determination based on acutal number of peered ports plus
>> if the bond has an active aggregrator. Specific notes are contained within each
>> patch.
>>
>> For this patch series there are no userspace facing changes, a diff between
>> the modinfo output showed no difference. However, there are behavioral
>> facing changes, primarily in the bond carrier state. Please make sure to
>> review carefully.
>>
>> Jonathan Toppins (1):
>> bonding: cleanup and remove dead code
>>
>> Satish Ashok (1):
>> bonding: fix LACP PDU not sent on slave port sometimes
>>
>> Scott Feldman (1):
>> bonding: keep bond interface carrier off until at least one active
>> member
>>
>> Wilson Kok (2):
>> bonding: fix bond_open() don't always set slave active flag
>> bonding: fix incorrect lacp mux state when agg not active
>>
>> drivers/net/bonding/bond_3ad.c | 73 ++++++++++++++++++++++++++++--------
>> drivers/net/bonding/bond_main.c | 6 +--
>> drivers/net/bonding/bond_options.c | 1 +
>> include/net/bond_3ad.h | 1 -
>> include/net/bonding.h | 1 +
>> 5 files changed, 62 insertions(+), 20 deletions(-)
>>
>
> Hi Jonathan,
> For all patches you should also CC the other maintainers of the bonding -
> Jay and Veaceslav, I'm adding them now just in case they've missed them.
> I have a few cosmetic nits which I don't have a strong feeling about i.e.
> if the others are okay with them - then ignore them, I've replied to the
> patches directly, but other than that you can add for the set my:
>
> Reviewed-by: Nikolay Aleksandrov <nikolay@redhat•com>
>
Hi Nikolay,
Appreciate the review... looking over comments now. Apologies for not
including other maintainers, will make sure to include them in v2 of
patch series.
next prev parent reply other threads:[~2015-01-19 20:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 15:57 [PATCH net-next 0/5] bonding: various 802.3ad fixes Jonathan Toppins
2015-01-16 15:57 ` [PATCH net-next 1/5] bonding: keep bond interface carrier off until at least one active member Jonathan Toppins
2015-01-19 19:27 ` Nikolay Aleksandrov
2015-01-19 20:54 ` Jonathan Toppins
2015-01-19 21:16 ` Jay Vosburgh
2015-01-21 5:22 ` Jonathan Toppins
2015-01-21 7:14 ` Jay Vosburgh
2015-01-23 23:04 ` Jonathan Toppins
2015-01-24 3:15 ` Jay Vosburgh
[not found] ` <CAE4R7bBzeO5MvL5zS5Piq6Ld2ZbD8smGx8XaJy5SvY7kHbX_Kw@mail.gmail.com>
2015-01-21 5:27 ` Jonathan Toppins
2015-01-16 15:57 ` [PATCH net-next 2/5] bonding: fix bond_open() don't always set slave active flag Jonathan Toppins
2015-01-16 15:57 ` [PATCH net-next 3/5] bonding: fix incorrect lacp mux state when agg not active Jonathan Toppins
2015-01-19 19:26 ` Nikolay Aleksandrov
2015-01-19 20:50 ` Jonathan Toppins
2015-01-19 20:56 ` David Miller
2015-01-16 15:57 ` [PATCH net-next 4/5] bonding: fix LACP PDU not sent on slave port sometimes Jonathan Toppins
2015-01-16 15:57 ` [PATCH net-next 5/5] bonding: cleanup and remove dead code Jonathan Toppins
2015-01-19 19:29 ` [PATCH net-next 0/5] bonding: various 802.3ad fixes Nikolay Aleksandrov
2015-01-19 20:39 ` Jonathan Toppins [this message]
2015-01-19 20:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD6B64.2010505@cumulusnetworks.com \
--to=jtoppins@cumulusnetworks$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@redhat$(echo .)com \
--cc=vfalico@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox