From: roopa <roopa@cumulusnetworks•com>
To: "Samudrala, Sridhar" <sridhar.samudrala@intel•com>
Cc: "Scott Feldman" <sfeldma@gmail•com>,
"stephen@networkplumber•org" <stephen@networkplumber•org>,
"David S. Miller" <davem@davemloft•net>,
"Jamal Hadi Salim" <jhs@mojatatu•com>,
"Jiří Pírko" <jiri@resnulli•us>,
"Arad, Ronen" <ronen.arad@intel•com>,
"Thomas Graf" <tgraf@suug•ch>,
"john fastabend" <john.fastabend@gmail•com>,
"vyasevic@redhat•com" <vyasevic@redhat•com>,
Netdev <netdev@vger•kernel.org>,
"Wilson Kok" <wkok@cumulusnetworks•com>,
"Andy Gospodarek" <gospo@cumulusnetworks•com>
Subject: Re: [RFC PATCH net-next] bridge: ability to disable forwarding on a port
Date: Tue, 20 Jan 2015 05:59:04 -0800 [thread overview]
Message-ID: <54BE5F28.5090706@cumulusnetworks.com> (raw)
In-Reply-To: <54BDFF20.9020909@intel.com>
On 1/19/15, 11:09 PM, Samudrala, Sridhar wrote:
>
> On 1/19/2015 10:20 PM, roopa wrote:
>> On 1/18/15, 11:37 PM, Scott Feldman wrote:
>>
>> <snip..>
>>>
>>> Not sure. I don't know the use case, but I think I might have heard
>>> that
>>> there could be a case
>>> where a switch port could be bridged with a vm's port running on the
>>> switch. (?)
>>>>
>>>> Ignoring the above usecase for a bit. And thinking through this
>>>> again, It
>>>> appears that this check should
>>>> be only on the ingress port, no ?
>>>>
>>>> If the ingress bridge port is an offloaded port, don't flood or
>>>> forward
>>>> because hardware has already done it.
>>>> And this is best done with the offload feature flag on the bridge
>>>> port.
>>> That's assuming hardware did the flood. Maybe your other option to
>>> mark the skb if already flooded by hw is best. That's enough info for
>>> the bridge driver to make a decision to flood or not to the other
>>> ports, and it's an implementation decision for the driver/device to do
>>> the flood offload, if desired, and mark the skb if it did.
>>
>> Still thinking we can just use the offload feature flag here. How
>> about avoid forwarding only if both src and dst ports have
>> forwarding offloaded/accelerated by a switch asic ?. That should
>> cover all cases.
>>>
>>> Btw, you're still saying flood or forward, but in my mind we're
>>> talking about flood only: flood of unknown unicast or flood of
>>> bcast/mcast pkts. Forwarding would be for known-unicast pkts, which
>>> should even involve the bridge driver since that forwarding is
>>> offloaded to the device.
>>
>> I was also taking into account pkts copied to the CPU due to an acl
>> rule such as log.
>> These unicast pkts can come to cpu even if it is already forwarded in
>> hw.
>
> Do you have a switch port netdev that corresponds to CPU port? Or are
> they seen on the bridge device?
No we dont have a netdev for the CPU port. These show up on the netdev
corresponding to the ingress front panel port.
prev parent reply other threads:[~2015-01-20 13:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 7:32 [RFC PATCH net-next] bridge: ability to disable forwarding on a port roopa
2015-01-17 21:14 ` Arad, Ronen
2015-01-18 8:48 ` roopa
2015-01-18 1:05 ` Scott Feldman
2015-01-18 9:10 ` roopa
2015-01-18 20:55 ` roopa
2015-01-19 7:37 ` Scott Feldman
2015-01-20 6:20 ` roopa
2015-01-20 7:09 ` Samudrala, Sridhar
2015-01-20 13:59 ` roopa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BE5F28.5090706@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gospo@cumulusnetworks$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=john.fastabend@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ronen.arad@intel$(echo .)com \
--cc=sfeldma@gmail$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
--cc=vyasevic@redhat$(echo .)com \
--cc=wkok@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox