Subject: Re: [PATCH net-next] rhashtable: rhashtable_remove() must unlink in both tbl and future_tbl

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 20 Jan 2015 21:44:09 +0300

Hello.

On 01/20/2015 07:58 PM, Thomas Graf wrote:

> As removals can occur during resizes, entries may be referred to from
> both tbl and future_tbl when the removal is requested. Therefore
> rhashtable_remove() must unlink the entry in both tables if this is
> the case. The existing code did search both tables but stopped when it
> hit the first match.

> Failing to do so resulted in use after remove.

    Er, failing to do what? Stopping when it hit the first match?

> Fixes: 97defe1 ("rhashtable: Per bucket locks & deferred expansion/shrinking")

    SHA1 should be 12 hex digits in this case, accordong to 
Documentation/SubmittingPatches.

> Reported-by: Ying Xue <[email-masked]>
> Signed-off-by: Thomas Graf <[email-masked]>

[...]

WBR, Sergei