From: Daniel Borkmann <dborkman@redhat•com>
To: Shaohua Li <shli@fb•com>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org, kafai@fb•com
Subject: Re: net_test_tools: add ipv6 support for kbench_mod
Date: Fri, 23 Jan 2015 10:55:41 +0100 [thread overview]
Message-ID: <54C21A9D.6080101@redhat.com> (raw)
In-Reply-To: <20150122221256.GA2263247@devbig257.prn2.facebook.com>
On 01/22/2015 11:12 PM, Shaohua Li wrote:
...
>>> Yes, we need export the sysmbol for the test. Can we export the symbol?
>>> or I can delete the route input test, which one do you prefer?
>>
>> There is no justification upstream to export that symbol since
>> there are no modular users in-tree.
>
> I changed it to do the ip6_route_input test optionally. If the test is
> required, somebody should change the kernel to export it and define
> HAVE_IP6_ROUTE_INPUT in the test module. I thought this is fine for a
> test module. How do you think?
See above, it can only be changed/exported from the kernel as long as
there is an in-tree module making use of it.
next prev parent reply other threads:[~2015-01-23 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 5:45 net_test_tools: add ipv6 support for kbench_mod Shaohua Li
2015-01-14 6:35 ` David Miller
2015-01-15 21:17 ` Shaohua Li
2015-01-15 23:08 ` David Miller
2015-01-22 22:12 ` Shaohua Li
2015-01-23 9:55 ` Daniel Borkmann [this message]
2015-01-23 15:58 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C21A9D.6080101@redhat.com \
--to=dborkman@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kafai@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shli@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox