Subject: Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

From: Stathis Voukelatos <[email-masked]>
Date: Mon, 26 Jan 2015 11:11:07 +0000

On 24/01/15 21:37, Joe Perches wrote:
> On Fri, 2015-01-23 at 10:07 +0000, Stathis Voukelatos wrote:
>> This patch adds support the Ethernet Packet Sniffer H/W module
>> developed by Linn Products Ltd and found in the IMG Pistachio SoC.
>> The module allows Ethernet packets to be parsed, matched against
>> a user-defined pattern and timestamped. It sits between a 100M
>> Ethernet MAC and PHY and is completely passive with respect to
>> Ethernet frames.
> []
>>   include/linux/pkt_sniffer.h                        |  89 +++++
> Why should this file be here?
> Why not in the drivers/net/pkt-sniffer directory?
>
Hi Joe,
Thank you for the feedback.
This header file is the public API for the driver.
Should it not live under the 'include' directory?
Several other drivers seem to follow that convention.

I will include your other suggestions in the next version
of the patch set.
Thank you,
Stathis