From: roopa <roopa@cumulusnetworks•com>
To: Scott Feldman <sfeldma@gmail•com>
Cc: Netdev <netdev@vger•kernel.org>,
shemminger@vyatta•com,
"vyasevic@redhat•com" <vyasevic@redhat•com>,
Wilson Kok <wkok@cumulusnetworks•com>
Subject: Re: [PATCH net-next v3 2/2] iproute2: bridge vlan show new option to print ranges
Date: Mon, 26 Jan 2015 10:57:25 -0800 [thread overview]
Message-ID: <54C68E15.9060002@cumulusnetworks.com> (raw)
In-Reply-To: <54C5DA02.30502@cumulusnetworks.com>
On 1/25/15, 10:09 PM, roopa wrote:
> On 1/25/15, 9:57 PM, Scott Feldman wrote:
>> On Sun, Jan 25, 2015 at 9:18 PM, roopa <roopa@cumulusnetworks•com>
>> wrote:
>>> On 1/25/15, 8:35 PM, Scott Feldman wrote:
>>>>> diff --git a/bridge/bridge.c b/bridge/bridge.c
>>>>> index 5fcc552..88469ca 100644
>>>>> --- a/bridge/bridge.c
>>>>> +++ b/bridge/bridge.c
>>>>> @@ -21,6 +21,7 @@ int resolve_hosts;
>>>>> int oneline = 0;
>>>>> int show_stats;
>>>>> int show_details;
>>>>> +int compress_vlans;
>>>>> int timestamp;
>>>>> char * _SL_ = NULL;
>>>>>
>>>>> @@ -32,7 +33,8 @@ static void usage(void)
>>>>> "Usage: bridge [ OPTIONS ] OBJECT { COMMAND | help }\n"
>>>>> "where OBJECT := { link | fdb | mdb | vlan | monitor }\n"
>>>>> " OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
>>>>> -" -o[neline] | -t[imestamp] | -n[etns] name
>>>>> }\n");
>>>>> +" -o[neline] | -t[imestamp] | -n[etns] name |\n"
>>>>> +" -c[ompressvlans] }\n");
>>>> This option is awkward at this level since it's specific to bridge
>>>> vlan
>>>> cmd.
>>>>
>>>> Is it even necessary? The real user of compressed vlans isn't the
>>>> "bridge show" cmd; just keep "bridge show" simple, listing each vlan
>>>> per line.
>>> without ranges it does get a bit difficult (or rather long) to read
>>> if there
>>> are many vlans (it was also a comment I received on v2).
>>>
>>> All the available options whether they apply to the immediate
>>> sub-command or
>>> not are at the toplevel command today.
>>> Hence the position (Not a big fan of the current name. suggestions
>>> welcome).
>>>
>>> I would have loved to have the default output print ranges, If that is
>>> acceptable. But, that can break new iproute2 on older kernels (If
>>> that is
>>> something we should care about).
>>>
>>> other option is keyword argument like maybe 'bridge vlan show
>>> compressed' or
>>> 'bridge vlan show ranges'
>> How about try RTEXT_FILTER_BRVLAN_COMPRESSED first, and if that fails,
>> try RTEXT_FILTER_BRVLAN, and don't add -c option?
>>
>>
> That would have been nice, except that it will not fail. It will pass
> but not return any vlans.
>
> Better would be to send both flags. I think that will work. New kernel
> looks at RTEXT_FILTER_BRVLAN_COMPRESSED first.
> v4 soon ....after some testing ... ;)
This still means i will end up changing the default/current output into
vlan ranges on newer kernels. If that is acceptable then i will resubmit
with v4.
If not, v3 looks ok to me so far.
thanks,
Roopa
prev parent reply other threads:[~2015-01-26 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 2:26 [PATCH net-next v3 2/2] iproute2: bridge vlan show new option to print ranges roopa
2015-01-26 4:35 ` Scott Feldman
2015-01-26 5:18 ` roopa
2015-01-26 5:57 ` Scott Feldman
2015-01-26 6:09 ` roopa
2015-01-26 18:57 ` roopa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C68E15.9060002@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
--cc=vyasevic@redhat$(echo .)com \
--cc=wkok@cumulusnetworks$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox