From: Vlastimil Setka <setka@vsis•cz>
To: vbridger@opensource•altera.com, netdev@vger•kernel.org,
rfi@lists•rocketboards.org
Subject: Altera TSE (altera_tse) - tx_fifo_depth init bug
Date: Tue, 27 Jan 2015 22:26:03 +0100 [thread overview]
Message-ID: <54C8026B.9070607@vsis.cz> (raw)
Hello,
I have discovered a bug in Altera TSE (altera_tse) ethernet driver.
In altera_tse_main.c, function altera_tse_probe:
if (of_property_read_u32(pdev->dev.of_node, "tx-fifo-depth",
&priv->rx_fifo_depth)) {
the TX related "tx-fifo-depth" is read from device tree, but by mistake
written to RX related struct member rx_fifo_depth instead of correct
tx_fifo_depth.
https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/altera/altera_tse_main.c#L1401
I am not sure about impact of this bug, but it seems that
priv->tx_fifo_depth is left uninitialised which is definitely not OK.
[PATCH 1/1] Altera TSE: Fix priv->tx_fifo_depth initialization
This patch fixes priv->tx_fifo_depth initialization in altera_tse_probe().
The "tx-fifo-depth" attribute was read again into rx_fifo_depth instead
of correct tx_fifo_depth probably because of copy-and-paste typo,
and tx_fifo_depth was left uninitialised.
Signed-off-by: Vlastimil Setka <setka@vsis•cz>
---
drivers/net/ethernet/altera/altera_tse_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c
b/drivers/net/ethernet/altera/altera_tse_main.c
index 760c72c..f3d784a 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -1399,7 +1399,7 @@ static int altera_tse_probe(struct platform_device
*pdev)
}
if (of_property_read_u32(pdev->dev.of_node, "tx-fifo-depth",
- &priv->rx_fifo_depth)) {
+ &priv->tx_fifo_depth)) {
dev_err(&pdev->dev, "cannot obtain tx-fifo-depth\n");
ret = -ENXIO;
goto err_free_netdev;
--
1.8.1.2
Regards,
Vlastimil Setka
next reply other threads:[~2015-01-27 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 21:26 Vlastimil Setka [this message]
2015-01-29 22:22 ` Altera TSE (altera_tse) - tx_fifo_depth init bug David Miller
2015-02-16 22:43 ` Vlastimil Setka
2015-02-20 20:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C8026B.9070607@vsis.cz \
--to=setka@vsis$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rfi@lists$(echo .)rocketboards.org \
--cc=vbridger@opensource$(echo .)altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox