From: roopa <roopa@cumulusnetworks•com>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, stephen@networkplumber•org, rami.rosen@intel•com
Subject: Re: [PATCH] bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify
Date: Wed, 28 Jan 2015 05:37:48 -0800 [thread overview]
Message-ID: <54C8E62C.5040603@cumulusnetworks.com> (raw)
In-Reply-To: <20150127.230511.1131199235284204820.davem@davemloft.net>
On 1/27/15, 11:05 PM, David Miller wrote:
> From: roopa@cumulusnetworks•com
> Date: Tue, 27 Jan 2015 21:46:24 -0800
>
>> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>>
>> Reported in: https://bugzilla.kernel.org/show_bug.cgi?id=92081
>>
>> This patch avoids calling rtnl_notify if the device ndo_bridge_getlink
>> handler does not return any bytes in the skb.
>>
>> Alternately, the skb->len check can be moved inside rtnl_notify.
>>
>> For the bridge vlan case described in 92081, there is also a fix needed
>> in bridge driver to generate a proper notification. Will fix that in
>> subsequent patch.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks•com>
> This doesn't apply to the 'net' tree, is there something I missed?
sorry, that's me. This should be net-next. Resubmitting with net-next in
the PATCH line.
thanks.
next prev parent reply other threads:[~2015-01-28 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 5:46 [PATCH] bridge: dont send notification when skb->len == 0 in rtnl_bridge_notify roopa
2015-01-28 7:05 ` David Miller
2015-01-28 13:37 ` roopa [this message]
2015-01-28 14:01 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C8E62C.5040603@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rami.rosen@intel$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox