From: Murali Karicheri <m-karicheri2-l0cyMroinI0@public•gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public•gmane.org>,
"Balbi, Felipe" <balbi-l0cyMroinI0@public•gmane.org>,
<mugunthanvnm-l0cyMroinI0@public•gmane.org>
Cc: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
<devicetree-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>,
<netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org>
Subject: Re: [PATCH net-next v8 0/4] net: Add Keystone NetCP ethernet driver support
Date: Thu, 29 Jan 2015 12:21:36 -0500 [thread overview]
Message-ID: <54CA6C20.5090301@ti.com> (raw)
In-Reply-To: <54C9654C.8030407-l0cyMroinI0@public.gmane.org>
On 01/28/2015 05:40 PM, Murali Karicheri wrote:
> + Felipe, Mugunthan for commenting on TI_CPSW, ALE.
>
--- Cut ------
>
>>
>> The second problem is where I got stuck myself: cpsw_ale.c (also cpts.c)
>> is getting linked into both modules, which is not allowed: It is
>> impossible for the kernel to compile these if one driver is a module
>> and the other one is not, and any use of KBUILD_MODNAME fails because
>> it is unclear what the modname is if the file is compiled once to
>> be linked into two drivers.
Arnd,
I think the solution is to make the cpsw_ale as a module and configured
through a Kconfig option. I am working on a fix for this now.
Similar fix is required for cpts.o. Currently we are not using this
module for Netcp, but soon this will be re-used. I have send a patch
that is already applied to net-next removing cpts.o for Netcp.
Murali
>
> I am still looking into this. Both Keystone and TI CPSW driver would
> need to use cpsw_ale.o and cpts.o (currently not used, but will need
> this later). Not found a solution yet.
>
> Murali
>>
>> Arnd
>
>
--
Murali Karicheri
Linux Kernel, Texas Instruments
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-29 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 0:10 [PATCH net-next v8 0/4] net: Add Keystone NetCP ethernet driver support Murali Karicheri
[not found] ` <1421367007-19744-1-git-send-email-m-karicheri2-l0cyMroinI0@public.gmane.org>
2015-01-19 20:11 ` David Miller
[not found] ` <20150119.151106.822126941934010309.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2015-01-20 15:53 ` Murali Karicheri
2015-01-27 22:28 ` Arnd Bergmann
2015-01-28 16:49 ` Murali Karicheri
2015-01-28 17:43 ` Murali Karicheri
2015-01-28 18:20 ` Murali Karicheri
2015-01-28 20:43 ` Murali Karicheri
2015-01-28 21:03 ` Arnd Bergmann
2015-01-28 22:40 ` Murali Karicheri
[not found] ` <54C9654C.8030407-l0cyMroinI0@public.gmane.org>
2015-01-29 17:21 ` Murali Karicheri [this message]
2015-01-29 22:00 ` Arnd Bergmann
2015-01-29 23:20 ` Murali Karicheri
2015-01-29 23:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA6C20.5090301@ti.com \
--to=m-karicheri2-l0cymroini0@public$(echo .)gmane.org \
--cc=arnd-r2nGTMty4D4@public$(echo .)gmane.org \
--cc=balbi-l0cyMroinI0@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=mugunthanvnm-l0cyMroinI0@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox