From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Steffen Klassert <steffen.klassert@secunet•com>
Cc: Fan Du <fan.du@intel•com>,
herbert@gondor•apana.org.au, davem@davemloft•net,
netdev@vger•kernel.org, fengyuleidian0615@gmail•com
Subject: Re: [PATCHv3, ipsec-next] xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host
Date: Mon, 02 Feb 2015 10:02:50 +0100 [thread overview]
Message-ID: <54CF3D3A.5040607@6wind.com> (raw)
In-Reply-To: <20150202084443.GS13046@secunet.com>
Le 02/02/2015 09:44, Steffen Klassert a écrit :
> On Thu, Jan 29, 2015 at 11:29:51AM +0100, Nicolas Dichtel wrote:
[snip]
>>
>> The point I try to make is that patching userland apps allows to use xfrm on a
>> 32bits userland / 64bits kernel.
>
> Ugh, I did not know that this is used that way. Which applications do this?
> So the situation is worse than I thought. What happens to such applications
> if we add a compat layer in the kernel? I'd guess they will break, right?
A compat layer will be perfect. I just wanted to highlight the fact that without
this patch, it's possible to have a workaround to use netlink-xfrm and after it,
it will be impossible.
>
>>
>> If I understand well your patch, it will not be possible anymore, all messages
>> will be rejected. And this may break existing apps.
>
> This patch would have been a quick solution without the case you
> mentioned. Now I fear we can't fix all cases, something will remain
> broken.
>
I think you're right, but having a proper solution is probably the best.
next prev parent reply other threads:[~2015-02-02 9:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150127.001226.711259930266409202.davem () davemloft ! net>
2015-01-27 9:00 ` [PATCHv3 ipsec-next] xfrm: Do not parse 32bits compiled xfrm netlink msg on 64bits host Fan Du
2015-01-27 9:46 ` David Laight
2015-01-27 11:04 ` Florian Westphal
2015-01-27 11:54 ` David Laight
2015-01-27 19:24 ` David Miller
2015-01-28 9:53 ` David Laight
2015-01-28 4:34 ` Fan Du
2015-01-29 10:29 ` [PATCHv3, " Nicolas Dichtel
2015-01-29 13:56 ` David Laight
2015-01-29 14:14 ` Nicolas Dichtel
2015-01-30 2:11 ` Fan Du
2015-02-02 8:44 ` Steffen Klassert
2015-02-02 9:02 ` Nicolas Dichtel [this message]
2015-02-02 19:45 ` David Miller
2015-02-03 12:24 ` Steffen Klassert
2015-02-03 14:02 ` Nicolas Dichtel
2015-03-06 6:13 ` [PATCHv3 " Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CF3D3A.5040607@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fan.du@intel$(echo .)com \
--cc=fengyuleidian0615@gmail$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox