Subject: Re: [PATCH net-next 2/9] be2net: replace (1 << x) with BIT(x)

From: Sergei Shtylyov <[email-masked]>
Date: Mon, 16 Feb 2015 15:09:24 +0300

Hello.

On 2/6/2015 4:18 PM, Sathya Perla wrote:

> From: Vasundhara Volam <[email-masked]>

> BIT(x) is the preffered usage.

    Preferred.

> Signed-off-by: Vasundhara Volam <[email-masked]>

> Signed-off-by: Sathya Perla <[email-masked]>
[...]

> diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
> index 3b1d59d..9869556 100644
> --- a/drivers/net/ethernet/emulex/benet/be.h
> +++ b/drivers/net/ethernet/emulex/benet/be.h
> @@ -361,15 +361,15 @@ enum vf_state {
>   	ASSIGNED = 1
>   };
>
> -#define BE_FLAGS_LINK_STATUS_INIT		1
> -#define BE_FLAGS_SRIOV_ENABLED			(1 << 2)
> -#define BE_FLAGS_WORKER_SCHEDULED		(1 << 3)
> -#define BE_FLAGS_VLAN_PROMISC			(1 << 4)
> -#define BE_FLAGS_MCAST_PROMISC			(1 << 5)
> -#define BE_FLAGS_NAPI_ENABLED			(1 << 9)
> -#define BE_FLAGS_QNQ_ASYNC_EVT_RCVD		(1 << 11)
> -#define BE_FLAGS_VXLAN_OFFLOADS			(1 << 12)
> -#define BE_FLAGS_SETUP_DONE			(1 << 13)
> +#define BE_FLAGS_LINK_STATUS_INIT		BIT(1)

    Not BIT(0)?

> +#define BE_FLAGS_SRIOV_ENABLED			BIT(2)
> +#define BE_FLAGS_WORKER_SCHEDULED		BIT(3)
> +#define BE_FLAGS_VLAN_PROMISC			BIT(4)
> +#define BE_FLAGS_MCAST_PROMISC			BIT(5)
> +#define BE_FLAGS_NAPI_ENABLED			BIT(6)
> +#define BE_FLAGS_QNQ_ASYNC_EVT_RCVD		BIT(7)
> +#define BE_FLAGS_VXLAN_OFFLOADS			BIT(8)
> +#define BE_FLAGS_SETUP_DONE			BIT(9)

    So, you decided to renumber the bits?

[...]

WBR, Sergei