Subject: Re: [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current_state()

From: Sergei Shtylyov <[email-masked]>
Date: Fri, 20 Feb 2015 21:34:28 +0300

Hello.

On 02/20/2015 09:12 PM, Fabian Frederick wrote:

> Use helper functions to access current->state.
> Direct assignments are prone to races and therefore buggy.

> current->state = TASK_RUNNING is replaced by __set_current_state()

    You sometimes use __set_current_state() and sometimes set_current_state().

> Thanks to Peter Zijlstra for the exact definition of the problem.

> Suggested-By: Peter Zijlstra <[email-masked]>
> Signed-off-by: Fabian Frederick <[email-masked]>

[...]

WBR, Sergei