From: Daniel Borkmann <daniel@iogearbox•net>
To: Josh Hunt <johunt@akamai•com>,
Pablo Neira Ayuso <pablo@netfilter•org>,
Patrick McHardy <kaber@trash•net>, Thomas Graf <tgraf@suug•ch>
Cc: netfilter-devel@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH v4 1/2] nft_hash: define max_shift rhashtable parameter
Date: Tue, 24 Feb 2015 19:16:07 +0100 [thread overview]
Message-ID: <54ECBFE7.1000103@iogearbox.net> (raw)
In-Reply-To: <1424801227-17320-2-git-send-email-johunt@akamai.com>
On 02/24/2015 07:07 PM, Josh Hunt wrote:
> You must define a max_shift parameter to rhashtable or else the table cannot
> grow. This sets max_shift for nft_hash to 24, which will allow the table to
> grow to 2^24 or 16 million buckets.
>
> Acked-by: Thomas Graf <tgraf@suug•ch>
> Signed-off-by: Josh Hunt <johunt@akamai•com>
Acked-by: Daniel Borkmann <daniel@iogearbox•net>
Thanks Josh!
next prev parent reply other threads:[~2015-02-24 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 18:07 [PATCH v4 0/2] nft hash resize fixes Josh Hunt
2015-02-24 18:07 ` [PATCH v4 1/2] nft_hash: define max_shift rhashtable parameter Josh Hunt
2015-02-24 18:16 ` Daniel Borkmann [this message]
2015-02-24 18:07 ` [PATCH v4 2/2] rhashtable: require max_shift if grow_decision defined Josh Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ECBFE7.1000103@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=johunt@akamai$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox