From: Guenter Roeck <linux@roeck-us•net>
To: Florian Fainelli <f.fainelli@gmail•com>, netdev@vger•kernel.org
Cc: davem@davemloft•net, vivien.didelot@savoirfairelinux•com,
jerome.oufella@savoirfairelinux•com, andrew@lunn•ch,
cphealy@gmail•com
Subject: Re: [PATCH net-next v3 2/3] net: dsa: integrate with SWITCHDEV for HW bridging
Date: Tue, 24 Feb 2015 21:44:28 -0800 [thread overview]
Message-ID: <54ED613C.3020409@roeck-us.net> (raw)
In-Reply-To: <1424812534-8936-3-git-send-email-f.fainelli@gmail.com>
On 02/24/2015 01:15 PM, Florian Fainelli wrote:
> In order to support bridging offloads in DSA switch drivers, select
> NET_SWITCHDEV to get access to the port_stp_update and parent_get_id
> NDOs that we are required to implement.
>
> To facilitate the integratation at the DSA driver level, we implement 3
> types of operations:
>
> - port_join_bridge
> - port_leave_bridge
> - port_stp_update
>
> DSA will resolve which switch ports that are currently bridge port
> members as some Switch hardware/drivers need to know about that to limit
> the register programming to just the relevant registers (especially for
> slow MDIO buses).
>
> We also take care of setting the correct STP state when slave network
> devices are brought up/down while being bridge members.
>
> Finally, when a port is leaving the bridge, we make sure we set in
> BR_STATE_FORWARDING state, otherwise the bridge layer would leave it
> disabled as a result of having left the bridge.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail•com>
Reviewed-by: Guenter Roeck <linux@roeck-us•net>
And with my code adding support for HW bridging to the mv88e6352 driver:
Tested-by: Guenter Roeck <linux@roeck-us•net>
Guenter
next prev parent reply other threads:[~2015-02-25 5:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 21:15 [PATCH net-next v3 0/3] net: dsa: integration with SWITCHDEV for HW bridging Florian Fainelli
2015-02-24 21:15 ` [PATCH net-next v3 1/3] net: dsa: Ensure that port array elements are initialized before being used Florian Fainelli
2015-02-24 21:15 ` [PATCH net-next v3 2/3] net: dsa: integrate with SWITCHDEV for HW bridging Florian Fainelli
2015-02-25 5:44 ` Guenter Roeck [this message]
2015-02-24 21:15 ` [PATCH net-next v3 3/3] net: dsa: bcm_sf2: add HW bridging support Florian Fainelli
2015-02-25 22:04 ` [PATCH net-next v3 0/3] net: dsa: integration with SWITCHDEV for HW bridging David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ED613C.3020409@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=andrew@lunn$(echo .)ch \
--cc=cphealy@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jerome.oufella@savoirfairelinux$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@savoirfairelinux$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox