From: Daniel Borkmann <daniel@iogearbox•net>
To: Eric Dumazet <eric.dumazet@gmail•com>, Patrick McHardy <kaber@trash•net>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail•com>,
David Laight <David.Laight@aculab•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"tgraf@suug•ch" <tgraf@suug•ch>,
"pablo@netfilter•org" <pablo@netfilter•org>,
"johunt@akamai•com" <johunt@akamai•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH net] rhashtable: use cond_resched()
Date: Thu, 26 Feb 2015 16:50:15 +0100 [thread overview]
Message-ID: <54EF40B7.8060903@iogearbox.net> (raw)
In-Reply-To: <1424964034.5565.162.camel@edumazet-glaptop2.roam.corp.google.com>
On 02/26/2015 04:20 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google•com>
>
> If a hash table has 128 slots and 16384 elems, expand to 256 slots
> takes more than one second. For larger sets, a soft lockup is detected.
>
> Holding cpu for that long, even in a work queue is a show stopper
> for non preemptable kernels.
>
> cond_resched() at strategic points to allow process scheduler
> to reschedule us.
>
> Signed-off-by: Eric Dumazet <edumazet@google•com>
Acked-by: Daniel Borkmann <daniel@iogearbox•net>
next prev parent reply other threads:[~2015-02-26 15:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 22:09 [PATCH net 2/2] rhashtable: remove indirection for grow/shrink decision functions Alexei Starovoitov
2015-02-26 7:53 ` Patrick McHardy
2015-02-26 8:54 ` Daniel Borkmann
2015-02-26 14:50 ` Eric Dumazet
2015-02-26 14:54 ` Patrick McHardy
2015-02-26 15:20 ` [PATCH net] rhashtable: use cond_resched() Eric Dumazet
2015-02-26 15:36 ` David Laight
2015-02-26 15:46 ` Patrick McHardy
2015-02-26 16:03 ` David Laight
2015-02-26 15:50 ` Daniel Borkmann [this message]
2015-02-27 22:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EF40B7.8060903@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=David.Laight@aculab$(echo .)com \
--cc=alexei.starovoitov@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=johunt@akamai$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox