Subject: Re: [PATCH net-next 2/5] sh_eth: WARN on access to a register not implemented in a particular chip

From: Sergei Shtylyov <[email-masked]>
Date: Fri, 27 Feb 2015 18:21:24 +0300

Hello.

On 2/26/2015 11:34 PM, Ben Hutchings wrote:

> Currently we may silently read/write a register at offset 0.  Change
> this to WARN and then ignore the write or read-back all-ones.

    I think reading non-existing registers would yield all 0s, not all 1s.
That's not x86. :-)

> Signed-off-by: Ben Hutchings <[email-masked]>

    Other than that, seems a great idea.

Acked-by: Sergei Shtylyov <[email-masked]>

WBR, Sergei