From: Daniel Borkmann <daniel@iogearbox•net>
To: Eric Dumazet <eric.dumazet@gmail•com>,
nicolas.dichtel@6wind•com, David Miller <davem@davemloft•net>
Cc: Cong Wang <xiyou.wangcong@gmail•com>, netdev@vger•kernel.org
Subject: Re: [PATCH] net: do not use rcu in rtnl_dump_ifinfo()
Date: Fri, 27 Feb 2015 18:19:27 +0100 [thread overview]
Message-ID: <54F0A71F.3040808@iogearbox.net> (raw)
In-Reply-To: <1425056838.5130.27.camel@edumazet-glaptop2.roam.corp.google.com>
On 02/27/2015 06:07 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google•com>
>
> We did a failed attempt in the past to only use rcu in rtnl dump
> operations (commit e67f88dd12f6 "net: dont hold rtnl mutex during
> netlink dump callbacks")
>
> Now that dumps are holding RTNL anyway, there is no need to also
> use rcu locking, as it forbids any scheduling ability, like
> GFP_KERNEL allocations that controlling path should use instead
> of GFP_ATOMIC whenever possible.
>
> This should fix following splat Cong Wang reported :
>
> ===============================
[ Btw, I think patchwork has an issue with above line when fetching
the mbox : it thinks commit description ends here. :(
Prefixing with a space char should help to not get it lost. ]
next prev parent reply other threads:[~2015-02-27 17:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 6:32 [Patch net] netns: avoid allocating idr when dumping info Cong Wang
2015-02-27 8:01 ` Eric Dumazet
2015-02-27 16:25 ` Nicolas Dichtel
2015-02-27 16:55 ` Eric Dumazet
2015-02-27 17:07 ` [PATCH] net: do not use rcu in rtnl_dump_ifinfo() Eric Dumazet
2015-02-27 17:19 ` Daniel Borkmann [this message]
2015-02-27 17:40 ` Eric Dumazet
2015-02-27 18:35 ` Cong Wang
2015-02-27 17:42 ` [PATCH v2 net] " Eric Dumazet
2015-02-28 0:43 ` Jεan Sacren
2015-02-28 1:05 ` Eric Dumazet
2015-03-01 5:29 ` David Miller
2015-02-27 17:28 ` [Patch net] netns: avoid allocating idr when dumping info Cong Wang
2015-02-27 17:48 ` Nicolas Dichtel
2015-02-28 0:56 ` Cong Wang
2015-02-28 6:17 ` Cong Wang
2015-02-27 18:04 ` Eric Dumazet
2015-02-28 0:48 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F0A71F.3040808@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox