From: Ido Shamay <idos@dev•mellanox.co.il>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>,
Or Gerlitz <ogerlitz@mellanox•com>,
"David S. Miller" <davem@davemloft•net>
Cc: netdev@vger•kernel.org, Amir Vadai <amirv@mellanox•com>,
Tal Alon <talal@mellanox•com>
Subject: Re: [PATCH net 2/2] net/mlx4_en: Disbale GRO for incoming loopback/selftest packets
Date: Mon, 02 Mar 2015 09:47:49 +0200 [thread overview]
Message-ID: <54F415A5.1020809@dev.mellanox.co.il> (raw)
In-Reply-To: <54F34B36.2010202@cogentembedded.com>
On 3/1/2015 7:24 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 3/1/2015 5:56 PM, Or Gerlitz wrote:
>
>> From: Ido Shamay <idos@mellanox•com>
>
>> Packets which are sent from the selftest (ethtool) flow, should not
>> be passed to the GRO stack but rather dropped by the driver after
>> validation.
>> To achieve that, we disable GRO for the duration of the selftest.
>
>> Fixes: dd65beac48a5 ("net/mlx4_en: Extend usage of napi_gro_frags")
>> Reported-by: Carol Soto <clsoto@linux•vnet.ibm.com>
>> Signed-off-by: Ido Shamay <idos@mellanox•com>
>> Signed-off-by: Or Gerlitz <ogerlitz@mellanox•com>
>> ---
>> drivers/net/ethernet/mellanox/mlx4/en_selftest.c | 8 +++++++-
>> 1 files changed, 7 insertions(+), 1 deletions(-)
>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_selftest.c
>> b/drivers/net/ethernet/mellanox/mlx4/en_selftest.c
>> index 2d8ee66..ac8870c 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/en_selftest.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/en_selftest.c
>> @@ -81,12 +81,14 @@ static int mlx4_en_test_loopback(struct
>> mlx4_en_priv *priv)
>> {
>> u32 loopback_ok = 0;
>> int i;
>> -
>> + bool gro_enabled;
>>
>> priv->loopback_ok = 0;
>> priv->validate_loopback = 1;
>> + gro_enabled = (priv->dev->features & NETIF_F_GRO);
>
> Parens not necessary here.
>
Will be fixed in V1, thanks.
Any chance checkpatch can identify such cases?
> [...]
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-03-02 7:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-01 14:56 [PATCH net 0/2] Mellanox driver fixes Or Gerlitz
2015-03-01 14:56 ` [PATCH net 1/2] net/mlx4_core: Fix wrong mask and error flow for the update-qp command Or Gerlitz
2015-03-01 14:56 ` [PATCH net 2/2] net/mlx4_en: Disbale GRO for incoming loopback/selftest packets Or Gerlitz
2015-03-01 17:24 ` Sergei Shtylyov
2015-03-02 7:47 ` Ido Shamay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F415A5.1020809@dev.mellanox.co.il \
--to=idos@dev$(echo .)mellanox.co.il \
--cc=amirv@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=talal@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox