Subject: Re: [PATCH net-next] rocker: check for BRIDGE_FLAGS_SELF in bridge setlink handler

From: John Fastabend <[email-masked]>
Date: Tue, 03 Mar 2015 20:15:46 -0800

On 03/03/2015 04:15 PM, [email-masked] wrote:
> From: Roopa Prabhu <[email-masked]>
>
> With the recent addition of the NETIF_F_HW_SWITCH_OFFLOAD flag
> on rocker ports, the second command (bridge link set) below will turn off
> learning in the rocker hw (Scott/Jiri, need some confirmation from
> you that this is indeed a problem and if the below patch is ok).
>
> ip link set dev swp1 master br0
> bridge link set dev swp1 learning off master
> bridge link set dev swp1 learning_sync on self
>
> This patch fixes rocker to ignore learning setting when 'master'
> is set. This makes it possible to set/unset learning in kernel and bridge
> driver independently.
>
> The below command will continue to set learning on in both kernel and rocker
> hw:
> bridge link set dev swp1 learning on
>
> Signed-off-by: Roopa Prabhu <[email-masked]>
> ---

We will at least want this behaviour in the NIC case where the NIC
can support l2 learning and forwarding to VF's or even other ports.
(remind again when a NIC becomes a switch and a switch becomes a NIC?).

In this case you may want to learn in the hardware but in the
hypervisor only support assigned MAC address because this is
controlled by a libvirt/qemu for example.

.John

-- 
John Fastabend         Intel Corporation