From: Sergei Shtylyov <sergei.shtylyov@cogentembedded•com>
To: Cong Wang <xiyou.wangcong@gmail•com>, netdev@vger•kernel.org
Cc: Jamal Hadi Salim <jhs@mojatatu•com>
Subject: Re: [Patch net-next] net_sched: move tp->root allocation into route4_init()
Date: Thu, 05 Mar 2015 17:26:13 +0300 [thread overview]
Message-ID: <54F86785.70906@cogentembedded.com> (raw)
In-Reply-To: <1425528704-21646-1-git-send-email-xiyou.wangcong@gmail.com>
Hello.
On 3/5/2015 7:11 AM, Cong Wang wrote:
> Cc: Jamal Hadi Salim <jhs@mojatatu•com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail•com>
> ---
> net/sched/cls_route.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
> diff --git a/net/sched/cls_route.c b/net/sched/cls_route.c
> index 2ecd246..bb8a602 100644
> --- a/net/sched/cls_route.c
> +++ b/net/sched/cls_route.c
> @@ -258,6 +258,13 @@ static unsigned long route4_get(struct tcf_proto *tp, u32 handle)
>
> static int route4_init(struct tcf_proto *tp)
> {
> + struct route4_head *head;
> +
> + head = kzalloc(sizeof(struct route4_head), GFP_KERNEL);
Hm, checkpatch.pl should have suggested using sizeof(*head) instead...
> + if (head == NULL)
And using !head instead.
> + return -ENOBUFS;
> +
> + rcu_assign_pointer(tp->root, head);
> return 0;
> }
WBR, Sergei
next prev parent reply other threads:[~2015-03-05 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 4:11 [Patch net-next] net_sched: move tp->root allocation into route4_init() Cong Wang
2015-03-05 4:11 ` [Patch net-next] net_sched: move tp->root allocation into fw_init() Cong Wang
2015-03-05 13:10 ` Jamal Hadi Salim
2015-03-06 2:31 ` David Miller
2015-03-05 13:09 ` [Patch net-next] net_sched: move tp->root allocation into route4_init() Jamal Hadi Salim
2015-03-05 14:26 ` Sergei Shtylyov [this message]
2015-03-06 2:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F86785.70906@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox