Subject: Re: [Linux-kernel] [net-next, 2/5] sh_eth: WARN on access to a register not implemented in a particular chip

From: Sergei Shtylyov <[email-masked]>
Date: Tue, 10 Mar 2015 23:03:43 +0300

Hello.

On 03/09/2015 11:50 AM, Ben Dooks wrote:

>>>> Currently we may silently read/write a register at offset 0.  Change
>>>> this to WARN and then ignore the write or read-back all-ones.

>>>> Signed-off-by: Ben Hutchings <[email-masked]>
>>>> Acked-by: Sergei Shtylyov <[email-masked]>

>>> While this may be a good idea for debugging...

>>>> --- a/drivers/net/ethernet/renesas/sh_eth.h
>>>> +++ b/drivers/net/ethernet/renesas/sh_eth.h
>>>> @@ -543,19 +543,29 @@ static inline void sh_eth_soft_swap(char *src, int len)
>>>>   #endif
>>>>   }
>>>>
>>>> +#define SH_ETH_OFFSET_INVALID	((u16) ~0)
>>>> +
>>>>   static inline void sh_eth_write(struct net_device *ndev, u32 data,
>>>>   				int enum_index)
>>>>   {
>>>>   	struct sh_eth_private *mdp = netdev_priv(ndev);

> does de-referencing this each time make a difference? Looks like

   It's not a dereference, it's just a pointer addition.

> it would have been easier to pass an "struct sh_eth_private" instead
> of the "struct net_device *ndev"

    Hm, maybe...

>>>> +	u16 offset = mdp->reg_offset[enum_index];
>>>> +
>>>> +	if (WARN_ON(offset == SH_ETH_OFFSET_INVALID))
>>>> +		return;

> You could cange the mdp->reg_offset to an mdp->reg_pointer and make
> any invalid registers a NULL. This would at-least make it fail on an
> invalid access.

    Interesting idea...

WBR, Sergei