Subject: Re: [PATCH net-next v2] tipc: fix undefined __ipv6_sock_mc_join compile error

From: Ying Xue <[email-masked]>
Date: Wed, 11 Mar 2015 11:40:03 +0800

On 03/10/2015 11:41 PM, Willem de Bruijn wrote:
>> l
>> > diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
>> > index fc2fb11..6763002 100644
>> > --- a/net/tipc/udp_media.c
>> > +++ b/net/tipc/udp_media.c
>> > @@ -247,10 +247,12 @@ static int enable_mcast(struct udp_bearer *ub, struct udp_media_addr *remote)
> 
>> >                 mreqn.imr_multiaddr = remote->ipv4;
>> >                 mreqn.imr_ifindex = ub->ifindex;
>> >                 err = __ip_mc_join_group(sk, &mreqn);
>> > +#if IS_ENABLED(CONFIG_IPV6)
>> >         } else {
>> >                 if (!ipv6_addr_is_multicast(&remote->ipv6))
>> >                         return 0;
>> >                 err = __ipv6_sock_mc_join(sk, ub->ifindex, &remote->ipv6);
>> > +#endif
>> >         }
>> >         return err;
> It may also be prudent to initialize err to -EAFNOSUPPORT instead of
> 0. This function is currently only called when the protocol family has
> been checked, but relying on that is a bit fragile.
> 
> 

Thanks for your suggestion, and I will fix it in next version.

Regards,
Ying