Subject: Re: [PATCH net-next v2] tipc: fix undefined __ipv6_sock_mc_join compile error

From: Ying Xue <[email-masked]>
Date: Wed, 11 Mar 2015 14:24:48 +0800

On 03/11/2015 12:05 PM, David Miller wrote:
> From: Ying Xue <[email-masked]>
> Date: Wed, 11 Mar 2015 11:11:37 +0800
> 
>> On 03/11/2015 12:47 AM, David Miller wrote:
>>> From: Willem de Bruijn <[email-masked]>
>>> Date: Tue, 10 Mar 2015 11:41:03 -0400
>>>
>>>> On Tue, Mar 10, 2015 at 4:41 AM, Ying Xue <[email-masked]> wrote:
>>>>> @@ -5,6 +5,7 @@
>>>>>  menuconfig TIPC
>>>>>         tristate "The TIPC Protocol"
>>>>>         depends on INET
>>>>> +       depends on (IPV6 || IPV6=n)
>>>>
>>>> Should this be limited to TIPC_MEDIA_UDP?
>>>
>>> I think it should.
>>>
>>>
>>
>> My first thought is also same as you. But when the dependency like (IPV6 ||
>> IPV6=n) is enforced to TIPC_MEDIA_UDP, it doesn't work in the below case:
>>
>> IPV6=m and TIPC=Y.
>>
>> In above condition, TIPC_MEDIA_UDP is still set to "Y".
> 
> It's because TIPC_MEDIA_UDP is bool, it needs to be a tristate.
> 

Yes, you are right. But as we don't implement UDP bearer as a module, I guess we
have to set TIPC_MEDIA_UDP as boolean type.

Regards,
Ying