Subject: Re: [PATCH net-next v3] tipc: fix undefined __ipv6_sock_mc_join compile error

From: Ying Xue <[email-masked]>
Date: Thu, 12 Mar 2015 11:35:04 +0800

On 03/12/2015 05:59 AM, David Miller wrote:
> From: Ying Xue <[email-masked]>
> Date: Wed, 11 Mar 2015 15:51:13 +0800
> 
>> diff --git a/net/tipc/Kconfig b/net/tipc/Kconfig
>> index c25a3a1..5bb8fc9 100644
>> --- a/net/tipc/Kconfig
>> +++ b/net/tipc/Kconfig
>> @@ -29,6 +29,7 @@ config TIPC_MEDIA_IB
>>  config TIPC_MEDIA_UDP
>>  	bool "IP/UDP media type support"
>>  	depends on TIPC
>> +	depends on (IPV6=y || IPV6=n)
>>  	select NET_UDP_TUNNEL
>>  	help
>>  	  Saying Y here will enable support for running TIPC over IP/UDP
> 
> This really is not what you want.
> 
> You want to enable TIPC_MEDIA_UDP if IPV6 is "compatible" with TIPC,
> what you're using here is a sledgehammer.
> 
> I would really suggest breaking this facility out into it's own
> module, then you can mark it tristate and do this correctly.
> 
> 

Thank you for the review. OK, I will change the code again following your
suggestions.

Regards,
Ying