From: Nicolas Dichtel <nicolas.dichtel@6wind•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
me@pierre-cheynier•net,
Steffen Klassert <steffen.klassert@secunet•com>
Subject: Re: [PATCH net] ip6_tunnel: fix error code when tunnel exists
Date: Fri, 13 Mar 2015 15:46:53 +0100 [thread overview]
Message-ID: <5502F85D.9050801@6wind.com> (raw)
In-Reply-To: <1426254227.11398.183.camel@edumazet-glaptop2.roam.corp.google.com>
Le 13/03/2015 14:43, Eric Dumazet a écrit :
[snip]
> These IS_ERR_OR_NULL(t) looks like defensive/lazy programming to me.
>
> A NULL pointer should not be allowed here.
>
> If t is not valid, it should be a plain error code mapping.
>
> I wish we get rid of all IS_ERR_OR_NULL() uses in networking tree,
> instead of adding plenty of them.
Ok, I agree. It was to minimize the patch.
I will rework it.
next prev parent reply other threads:[~2015-03-13 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 12:58 [PATCH net] ip6_tunnel: fix error code when tunnel exists Nicolas Dichtel
2015-03-13 13:43 ` Eric Dumazet
2015-03-13 14:46 ` Nicolas Dichtel [this message]
2015-03-13 16:32 ` David Miller
2015-03-16 14:56 ` [PATCH net v2] " Nicolas Dichtel
2015-03-16 20:34 ` David Miller
2015-03-17 8:27 ` Nicolas Dichtel
2015-03-17 19:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5502F85D.9050801@6wind.com \
--to=nicolas.dichtel@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=me@pierre-cheynier$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox