From: Daniel Borkmann <daniel@iogearbox•net>
To: Alexei Starovoitov <ast@plumgrid•com>, davem@davemloft•net
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next 1/2] ebpf: add prandom helper for packet sampling
Date: Fri, 13 Mar 2015 18:03:28 +0100 [thread overview]
Message-ID: <55031860.20903@iogearbox.net> (raw)
In-Reply-To: <55031730.5030303@plumgrid.com>
On 03/13/2015 05:58 PM, Alexei Starovoitov wrote:
> On 3/13/15 6:22 AM, Daniel Borkmann wrote:
>>
>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
>> index 3fa1af8..4efc41f 100644
>> --- a/include/uapi/linux/bpf.h
>> +++ b/include/uapi/linux/bpf.h
>> @@ -165,6 +165,7 @@ enum bpf_func_id {
>> BPF_FUNC_map_lookup_elem, /* void *map_lookup_elem(&map, &key) */
>> BPF_FUNC_map_update_elem, /* int map_update_elem(&map, &key, &value, flags) */
>> BPF_FUNC_map_delete_elem, /* int map_delete_elem(&map, &key) */
>> + BPF_FUNC_random, /* prandom() as u32 or u64 */
>
> can you rename it to BPF_FUNC_get_random_value ?
> I'd like names to be as descriptive as possible.
Ok, sure.
> User space can pick any name it likes anyway:
> static u64 (*my_foo_func)() = (void *) BPF_FUNC_get_random_value;
>
> Also it will make the following less obscure:
> > +extern const struct bpf_func_proto bpf_random_proto;
>
> 'bpf_get_random_value_proto' looks better then 'bpf_random_proto' ;)
>
>> +static u64 bpf_random(u64 dw, u64 r2, u64 r3, u64 r4, u64 r5)
>> +{
>> + return prandom_u32() | (dw ? ((u64)prandom_u32() << 32) : 0);
>
> can you make first argument to be a flag instead of bool ?
> 0 to return u32, 1 to return u64 and >=2 to be reserved and
> return -EINVAL?
> This way we can extend it later. For example 2 might return
> 8 truly random bytes from get_random_bytes_arch()
Yes, that's better.
>> +const struct bpf_func_proto bpf_random_proto = {
>> + .func = bpf_random,
>> + .gpl_only = false,
>
> non-gpl allowed?
> well I guess prandom_u32() is non-gpl either.
It can be used by anyone, yes. If there are strong opinions to make
this GPL-only, I don't mind, but I think it might be exaggerated.
Will respin.
Thanks,
Daniel
next prev parent reply other threads:[~2015-03-13 17:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 13:22 [PATCH net-next 0/2] eBPF updates Daniel Borkmann
2015-03-13 13:22 ` [PATCH net-next 1/2] ebpf: add prandom helper for packet sampling Daniel Borkmann
2015-03-13 16:58 ` Alexei Starovoitov
2015-03-13 17:03 ` Daniel Borkmann [this message]
2015-03-13 22:44 ` Daniel Borkmann
2015-03-13 22:53 ` Alexei Starovoitov
2015-03-14 0:11 ` Daniel Borkmann
2015-03-13 13:22 ` [PATCH net-next 2/2] ebpf: add helper for obtaining current processor id Daniel Borkmann
2015-03-13 17:06 ` Alexei Starovoitov
2015-03-13 17:08 ` Daniel Borkmann
2015-03-16 1:57 ` [PATCH net-next 0/2] eBPF updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55031860.20903@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=ast@plumgrid$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox