From: roopa <roopa@cumulusnetworks•com>
To: Venkat Venkatsubra <venkat.x.venkatsubra@oracle•com>
Cc: netdev@vger•kernel.org, davem@davemloft•net
Subject: Re: [PATCH] bridge: reset bridge mtu after deleting an interface
Date: Fri, 13 Mar 2015 19:12:52 -0700 [thread overview]
Message-ID: <55039924.3050609@cumulusnetworks.com> (raw)
In-Reply-To: <20150313140822.GA30448@oracle.com>
On 3/13/15, 7:08 AM, Venkat Venkatsubra wrote:
> On adding an interface br_add_if() sets the MTU to the min of
> all the interfaces. Do the same thing on removing an interface too
> in br_del_if.
>
> Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle•com>
> ---
> net/bridge/br_if.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> index b087d27..1849d96 100644
> --- a/net/bridge/br_if.c
> +++ b/net/bridge/br_if.c
> @@ -563,6 +563,8 @@ int br_del_if(struct net_bridge *br, struct net_device *dev)
> */
> del_nbp(p);
>
> + dev_set_mtu(br->dev, br_min_mtu(br));
> +
> spin_lock_bh(&br->lock);
> changed_addr = br_stp_recalculate_bridge_id(br);
> spin_unlock_bh(&br->lock);
This looks good to me.
Acked-by: Roopa Prabhu <roopa@cumulusnetworks•com>
next prev parent reply other threads:[~2015-03-14 2:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 14:08 [PATCH] bridge: reset bridge mtu after deleting an interface Venkat Venkatsubra
2015-03-14 2:12 ` roopa [this message]
2015-03-14 23:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55039924.3050609@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=venkat.x.venkatsubra@oracle$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox