From: roopa <roopa@cumulusnetworks•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, davem@davemloft•net, sfeldma@gmail•com
Subject: Re: [patch net-next] switchdev: call bridge setlink/dellink ndos recursively
Date: Mon, 16 Mar 2015 10:07:02 -0700 [thread overview]
Message-ID: <55070DB6.7020504@cumulusnetworks.com> (raw)
In-Reply-To: <20150316163638.GI2058@nanopsycho.orion>
On 3/16/15, 9:36 AM, Jiri Pirko wrote:
> Mon, Mar 16, 2015 at 04:21:03PM CET, roopa@cumulusnetworks•com wrote:
>> On 3/16/15, 7:22 AM, Jiri Pirko wrote:
>>> There has been a discussion about if it's better to let masters to
>>> propagate call down themself or if its better just blindly go down and
>>> try to call ndo on every lower netdev. Turned out that more people (me
>>> not included) like the second option better.
>>>
>>> This patch changes bridge setlink/dellink in that direction.
>>> Sorry Roopa for forcing you to do it the way I liked initially.
>>>
>>> Signed-off-by: Jiri Pirko <jiri@resnulli•us>
>> no worries. thanks for submitting the patch Jiri.
>>
>> One thing though (Which i also mentioned in one of the threads on this),
>> the below command will not work with layered devices with the below patch.
>> Because 'self' commands will directly try to find the switch port driver from
>> rtnetlink.c and they dont use the switch dev api.
>>
>> bridge link set dev bond0 learning off self
>>
>>
>> The code that currently exists in the tree with bond and team supporting the
>> op
>> will actually work.
> Hmm, interesting.
>
> DaveM, this might be a good argument for call propagation. What do you
> think?
>
For the stp api, it is not...because stp is run in the bridge driver and
always involves the switchdev api.
lets hold on to in-tree getlink/setlink before we find a better way.
my 2c
next prev parent reply other threads:[~2015-03-16 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 14:22 [patch net-next] switchdev: call bridge setlink/dellink ndos recursively Jiri Pirko
2015-03-16 15:21 ` roopa
2015-03-16 16:36 ` Jiri Pirko
2015-03-16 17:07 ` roopa [this message]
2015-03-16 17:37 ` Jiri Pirko
2015-03-16 22:08 ` John Fastabend
2015-03-17 7:05 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55070DB6.7020504@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox