From: Daniel Borkmann <daniel@iogearbox•net>
To: Alexei Starovoitov <ast@plumgrid•com>, stephen@networkplumber•org
Cc: jhs@mojatatu•com, jiri@resnulli•us, netdev@vger•kernel.org
Subject: Re: [PATCH iproute2 -next 2/2] tc: add eBPF support to f_bpf
Date: Mon, 16 Mar 2015 18:49:21 +0100 [thread overview]
Message-ID: <550717A1.2040805@iogearbox.net> (raw)
In-Reply-To: <550716BF.9030607@plumgrid.com>
On 03/16/2015 06:45 PM, Alexei Starovoitov wrote:
> On 3/16/15 10:10 AM, Daniel Borkmann wrote:
>
>> +
>> +/* ELF section names, etc (ABI) */
>> +#define ELF_SECTION_LICENSE "license"
>> +#define ELF_SECTION_MAPS "maps"
>> +#define ELF_SECTION_CLASSIFIER "classifier"
>> +#define ELF_SECTION_ACTION "action"
>> +
>> +#define ELF_MAX_MAPS 64
>> +#define ELF_MAX_LICENSE_LEN 128
>> +
>> +/* ELF map definition (ABI) */
>> +struct bpf_elf_map {
>> + __u32 type;
>> + __u32 size_key;
>> + __u32 size_value;
>> + __u32 max_elem;
>> +};
>
> I think people might freak out that the above section names and
> the struct are a kernel ABI. It's obviously not.
> Would be good to say that this is a present convention between
> C program that describes tc classifier and tc elf reader
> and it can change in the future.
Ohh, well, it's not a kernel ABI. I actually don't intend to change
the section names either as we don't want to break tc users. I could
imagine aliases if truly necessary.
I guess, I'll elaborate on the comment, sure.
prev parent reply other threads:[~2015-03-16 17:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 17:10 [PATCH iproute2 -next 0/2] f_bpf update Daniel Borkmann
2015-03-16 17:10 ` [PATCH iproute2 -next 1/2] misc: header rebase, add bpf.h Daniel Borkmann
2015-03-16 17:10 ` [PATCH iproute2 -next 2/2] tc: add eBPF support to f_bpf Daniel Borkmann
2015-03-16 17:45 ` Alexei Starovoitov
2015-03-16 17:49 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550717A1.2040805@iogearbox.net \
--to=daniel@iogearbox$(echo .)net \
--cc=ast@plumgrid$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox