From: roopa <roopa@cumulusnetworks•com>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: davem@davemloft•net, sfeldma@gmail•com, jiri@resnulli•us,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next v4] switchdev: fix stp update API to work with layered netdevices
Date: Tue, 17 Mar 2015 15:39:24 -0700 [thread overview]
Message-ID: <5508AD1C.4000905@cumulusnetworks.com> (raw)
In-Reply-To: <55074A75.1080604@gmail.com>
On 3/16/15, 2:26 PM, Florian Fainelli wrote:
> On 16/03/15 10:32, roopa@cumulusnetworks•com wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks•com>
>>
>> make it same as the netdev_switch_port_bridge_setlink/dellink
>> api (ie traverse lowerdevs to get to the switch port).
>>
>> removes "WARN_ON(!ops->ndo_switch_parent_id_get)" because
>> direct bridge ports can be stacked netdevices (like bonds
>> and team of switch ports) which may not imeplement this ndo.
>>
>> v2 to v3:
>> - remove changes to bond and team. Bring back the
>> transparently following lowerdevs like i initially
>> had for setlink/getlink
>> (http://www.spinics.net/lists/netdev/msg313436.html)
>> dave and scott feldman also seem to prefer it be that
>> way and move to non-transparent way of doing things
>> if we see a problem down the lane.
>>
>> v3 to v4:
>> - fix ret initialization
> The changelog should be after "---" otherwise it will get included in
> the final git commit, we don't want that as this changelog only makes
> sense during the submission process.
>
ack, thanks..will fix it when i respin the patch.
next prev parent reply other threads:[~2015-03-17 22:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 17:32 [PATCH net-next v4] switchdev: fix stp update API to work with layered netdevices roopa
2015-03-16 17:36 ` Jiri Pirko
2015-03-16 21:26 ` Florian Fainelli
2015-03-17 22:39 ` roopa [this message]
2015-03-17 6:10 ` Scott Feldman
2015-03-17 12:42 ` roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5508AD1C.4000905@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox