From: Nicolas Ferre <nicolas.ferre@atmel•com>
To: Ben Dooks <ben.dooks@codethink•co.uk>,
Marc Kleine-Budde <mkl@pengutronix•de>,
<linux-can@vger•kernel.org>
Cc: <linux-kernel@lists•codethink.co.uk>,
<linux-arm-kernel@lists•infradead.org>,
Wolfgang Grandegger <wg@grandegger•com>, <netdev@vger•kernel.org>
Subject: Re: [PATCH 11/13] can: at91_can: use endian agnostic IO accessors
Date: Thu, 19 Mar 2015 17:47:26 +0100 [thread overview]
Message-ID: <550AFD9E.60801@atmel.com> (raw)
In-Reply-To: <1426693992-31163-12-git-send-email-ben.dooks@codethink.co.uk>
Le 18/03/2015 16:53, Ben Dooks a écrit :
> Change __raw accesors to endian agnostic versions to allow the driver
> to work properly on big endian systems.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink•co.uk>
> --
> CC: Wolfgang Grandegger <wg@grandegger•com>
> CC: Marc Kleine-Budde <mkl@pengutronix•de>
> CC: linux-can@vger•kernel.org
> CC: netdev@vger•kernel.org
> CC: Nicolas Ferre <nicolas.ferre@atmel•com>
Sure!
Acked-by: Nicolas Ferre <nicolas.ferre@atmel•com>
Thanks, bye.
> ---
> drivers/net/can/at91_can.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
> index eeb4b8b..f4e40aa 100644
> --- a/drivers/net/can/at91_can.c
> +++ b/drivers/net/can/at91_can.c
> @@ -291,13 +291,13 @@ static inline unsigned int get_tx_echo_mb(const struct at91_priv *priv)
>
> static inline u32 at91_read(const struct at91_priv *priv, enum at91_reg reg)
> {
> - return __raw_readl(priv->reg_base + reg);
> + return readl_relaxed(priv->reg_base + reg);
> }
>
> static inline void at91_write(const struct at91_priv *priv, enum at91_reg reg,
> u32 value)
> {
> - __raw_writel(value, priv->reg_base + reg);
> + writel_relaxed(value, priv->reg_base + reg);
> }
>
> static inline void set_mb_mode_prio(const struct at91_priv *priv,
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-03-19 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1426693992-31163-1-git-send-email-ben.dooks@codethink.co.uk>
2015-03-18 15:53 ` [PATCH 11/13] can: at91_can: use endian agnostic IO accessors Ben Dooks
2015-03-19 16:47 ` Nicolas Ferre [this message]
2015-03-20 9:06 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550AFD9E.60801@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=ben.dooks@codethink$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-kernel@lists$(echo .)codethink.co.uk \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox