Subject: Re: [PATCH v2] tipc: fix build issue when building without IPv6

From: Ying Xue <[email-masked]>
Date: Fri, 20 Mar 2015 10:09:26 +0800

On 03/20/2015 04:06 AM, David Miller wrote:
> From: Marcelo Ricardo Leitner <[email-masked]>
> Date: Thu, 19 Mar 2015 16:47:58 -0300
> 
>> We can't directly call ipv6_sock_mc_join() but should use the stub
>> instead and protect it around IS_ENABLED.
>>
>> Fixes: d0f91938bede ("tipc: add ip/udp media type")
>> Signed-off-by: Marcelo Ricardo Leitner <[email-masked]>
> 

Sorry, this patch doesn't work at all especially when IPV6=m and TIPC=y. For
example, when we use the combination of the kernel config options, error appears
like:

net/built-in.o: In function `tipc_udp_send_msg':
/home/ying/work/tipc/tipc2.0/net-next-2.6-debug/net/tipc/udp_media.c:196:
undefined reference to `ip6_dst_lookup'
make: *** [vmlinux] Error 1

Instead, I ever tried to fix the issue several days ago. Please refer to the thread:

https://patchwork.ozlabs.org/patch/448836/

According to the suggestion David gave lastly, we should separate the UDP media
as an independent module, make TIPC_MEDIA_UDP depend on (IPV6 || IPV6=n), and
mark TIPC_MEDIA_UDP tristate. Now I am busy doing this following the proposal.

Regards,
Ying

> This works better, applied, thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [email-masked]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
>