From: Alexei Starovoitov <ast@plumgrid•com>
To: Daniel Borkmann <daniel@iogearbox•net>, davem@davemloft•net
Cc: jiri@resnulli•us, netdev@vger•kernel.org
Subject: Re: [PATCH net-next 1/2] ebpf: add sched_act_type and map it to sk_filter's verifier ops
Date: Fri, 20 Mar 2015 14:11:58 -0700 [thread overview]
Message-ID: <550C8D1E.6070502@plumgrid.com> (raw)
In-Reply-To: <3f1f15c00b7dd9899035696eef924b23a008afc2.1426859241.git.daniel@iogearbox.net>
On 3/20/15 7:11 AM, Daniel Borkmann wrote:
> In order to prepare eBPF support for tc action, we need to add
> sched_act_type, so that the eBPF verifier is aware of what helper
> function act_bpf may use, that it can load skb data and read out
> currently available skb fields.
>
> This is bascially analogous to 96be4325f443 ("ebpf: add sched_cls_type
> and map it to sk_filter's verifier ops").
>
> BPF_PROG_TYPE_SCHED_CLS and BPF_PROG_TYPE_SCHED_ACT need to be
> separate since both will have a different set of functionality in
> future (classifier vs action), thus we won't run into ABI troubles
> when the point in time comes to diverge functionality from the
> classifier.
>
> The future plan for act_bpf would be that it will be able to write
> into skb->data and alter selected fields mirrored in struct __sk_buff.
>
> For an initial support, it's sufficient to map it to sk_filter_ops.
>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox•net>
> Cc: Jiri Pirko <jiri@resnulli•us>
Acked-by: Alexei Starovoitov <ast@plumgrid•com>
next prev parent reply other threads:[~2015-03-20 21:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 14:11 [PATCH net-next 0/2] act_bpf update Daniel Borkmann
2015-03-20 14:11 ` [PATCH net-next 1/2] ebpf: add sched_act_type and map it to sk_filter's verifier ops Daniel Borkmann
2015-03-20 14:21 ` Jiri Pirko
2015-03-20 21:11 ` Alexei Starovoitov [this message]
2015-03-20 14:11 ` [PATCH net-next 2/2] act_bpf: add initial eBPF support for actions Daniel Borkmann
2015-03-20 14:30 ` Jiri Pirko
2015-03-20 21:21 ` Alexei Starovoitov
2015-03-20 20:22 ` [PATCH net-next 0/2] act_bpf update David Miller
2015-03-20 21:10 ` Daniel Borkmann
2015-03-20 21:26 ` Alexei Starovoitov
2015-03-20 22:21 ` David Miller
2015-03-20 22:45 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C8D1E.6070502@plumgrid.com \
--to=ast@plumgrid$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox