From: Alexei Starovoitov <ast-uqk4Ao+rVK5Wk0Htik3J/w@public•gmane.org>
To: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public•gmane.org>
Cc: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org>,
Namhyung Kim <namhyung-DgEjT+Ai2ygdnm+yROfE0A@public•gmane.org>,
Arnaldo Carvalho de Melo
<acme-wEGCiKHe2LqWVfeAwA7xHQ@public•gmane.org>,
Jiri Olsa <jolsa-H+wXaHxf7aLQT0dZR+AlfA@public•gmane.org>,
Masami Hiramatsu
<masami.hiramatsu.pt-FCd8Q96Dh0JBDgjK7y7TUQ@public•gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public•gmane.org>,
Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public•gmane.org>,
Peter Zijlstra
<a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public•gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
Subject: Re: [PATCH v8 tip 3/9] tracing: attach BPF programs to kprobes
Date: Fri, 20 Mar 2015 14:38:40 -0700 [thread overview]
Message-ID: <550C9360.7060207@plumgrid.com> (raw)
In-Reply-To: <20150320170907.388d8c33-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
On 3/20/15 2:09 PM, Steven Rostedt wrote:
>
>> +/**
>> + * trace_call_bpf - invoke BPF program
>> + * @prog - BPF program
>> + * @ctx - opaque context pointer
>> + *
>> + * kprobe handlers execute BPF programs via this helper.
>> + * Can be used from static tracepoints in the future.
>
> Should also state what the expected return values are. What does a
> return of "1" mean?
In earlier versions of this set I had detailed description of return
values from bpf program, somehow it got lost after all the revisions.
Will re-add.
> You are no longer in the net/ world. The rest of the Linux coding style
> is:
>
> /*
> * multi line comments
> */
>
> Only DaveM gets away with that format ;-)
:)
since bpf was born in the net/ world all comments are in that style.
When it moved into kernel/bpf/ we've decided to keep net/ style in there
as well, but for this file I don't mind using !net style ;)
> Reviewed-by: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public•gmane.org>
Thanks a lot. Will respin.
next prev parent reply other threads:[~2015-03-20 21:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 1:59 [PATCH v8 tip 0/9] tracing: attach eBPF programs to kprobes Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 1/9] bpf: make internal bpf API independent of CONFIG_BPF_SYSCALL ifdefs Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 3/9] tracing: attach BPF programs to kprobes Alexei Starovoitov
2015-03-20 21:09 ` Steven Rostedt
[not found] ` <20150320170907.388d8c33-f9ZlEuEWxVcJvu8Pb33WZ0EMvNT87kid@public.gmane.org>
2015-03-20 21:38 ` Alexei Starovoitov [this message]
2015-03-20 1:59 ` [PATCH v8 tip 4/9] tracing: allow BPF programs to call bpf_ktime_get_ns() Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk() Alexei Starovoitov
2015-03-20 21:22 ` Steven Rostedt
2015-03-20 21:44 ` Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 6/9] samples: bpf: simple non-portable kprobe filter example Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 7/9] samples: bpf: counting example for kfree_skb and write syscall Alexei Starovoitov
[not found] ` <1426816787-5001-1-git-send-email-ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-20 1:59 ` [PATCH v8 tip 2/9] tracing: add kprobe flag Alexei Starovoitov
2015-03-20 20:11 ` Steven Rostedt
2015-03-20 1:59 ` [PATCH v8 tip 8/9] samples: bpf: IO latency analysis (iosnoop/heatmap) Alexei Starovoitov
2015-03-20 1:59 ` [PATCH v8 tip 9/9] samples: bpf: kmem_alloc/free tracker Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C9360.7060207@plumgrid.com \
--to=ast-uqk4ao+rvk5wk0htik3j/w@public$(echo .)gmane.org \
--cc=a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public$(echo .)gmane.org \
--cc=acme-wEGCiKHe2LqWVfeAwA7xHQ@public$(echo .)gmane.org \
--cc=daniel-FeC+5ew28dpmcu3hnIyYJQ@public$(echo .)gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public$(echo .)gmane.org \
--cc=jolsa-H+wXaHxf7aLQT0dZR+AlfA@public$(echo .)gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=masami.hiramatsu.pt-FCd8Q96Dh0JBDgjK7y7TUQ@public$(echo .)gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public$(echo .)gmane.org \
--cc=namhyung-DgEjT+Ai2ygdnm+yROfE0A@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox