Subject: Re: [PATCH] net: dsa: make NET_DSA manually selectable from the config

From: Sergei Shtylyov <[email-masked]>
Date: Sun, 22 Mar 2015 20:58:32 +0300

Hello.

On 3/21/2015 4:31 AM, Mathieu Olivari wrote:

> Change bd76a116707bd2381da36cf7c3183df11293f1d6 made all DSA drivers

    s/Change/Commit/, perhaps?
    And please also specify that commit's summary line in parens.

> depend on NET_DSA rather than selecting them. However, as the only way
> to select this option was to actually select a driver, it made DSA
> impossible to enable at all.

> This patch adds an explicit entry which the user will have to enable
> prior selecting a driver.

> Signed-off-by: Mathieu Olivari <[email-masked]>
> ---
>   net/dsa/Kconfig | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)

> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
> index 087e654..4f3cce1 100644
> --- a/net/dsa/Kconfig
> +++ b/net/dsa/Kconfig
> @@ -5,9 +5,12 @@ config HAVE_NET_DSA
>   # Drivers must select NET_DSA and the appropriate tagging format
>
>   config NET_DSA
> -	tristate
> +	tristate "Distributed Switch Architecture"
>   	depends on HAVE_NET_DSA && NET_SWITCHDEV
>   	select PHYLIB
> +	---help---

    Hm, why not just help?

WBR, Sergei