From: Ying Xue <ying.xue@windriver•com>
To: Marcelo <marcelo.leitner@gmail•com>
Cc: David Miller <davem@davemloft•net>, <richard.alpe@ericsson•com>,
<jon.maloy@ericsson•com>, <netdev@vger•kernel.org>,
<tipc-discussion@lists•sourceforge.net>,
<erik.hugne@ericsson•com>
Subject: Re: [PATCH v2] tipc: fix build issue when building without IPv6
Date: Mon, 23 Mar 2015 11:00:17 +0800 [thread overview]
Message-ID: <550F81C1.4020701@windriver.com> (raw)
In-Reply-To: <9df97f7f63e5c844ede07f1e6ec45c4e@propriete.com.br>
On 03/20/2015 08:35 PM, Marcelo wrote:
> I think David and Willem suggestion were more about the dependencies
> than fixing the build issue itself. I mean, if some part of TIPC really
> needs IPv6 in order to work or something like that.
>
> So if all we want to do if fix the build issue, I have another suggestion.
> When we have IPV6=m and TIPC=y, just have to use the stub too.
>
> (cut & pasted)
> --- a/net/tipc/udp_media.c
> +++ b/net/tipc/udp_media.c
> @@ -193,7 +193,7 @@ static int tipc_udp_send_msg(struct net *net, struct
> sk_buff *skb,
> .saddr = src->ipv6,
> .flowi6_proto = IPPROTO_UDP
> };
> - err = ip6_dst_lookup(ub->ubsock->sk, &ndst, &fl6);
> + err = ipv6_stub->ipv6_dst_lookup(ub->ubsock->sk, &ndst,
> &fl6);
> if (err)
> goto tx_error;
> ttl = ip6_dst_hoplimit(ndst);
>
> then it builds fine here. That is, assuming that you can't reach this code
> while
> ipv6 module is unloaded.. (I didn't check that) what do you think?
It seems that your above change is useless to kill the error. For instance, when
I apply it into my project, below build error appears:
net/tipc/udp_media.c: In function ‘tipc_udp_send_msg’:
net/tipc/udp_media.c:196:18: error: ‘const struct ipv6_stub’ has no member named
‘ip6_dst_lookup’
make[2]: *** [net/tipc/udp_media.o] Error 1
make[1]: *** [net/tipc] Error 2
make: *** [net] Error 2
In my opinion, we have to follow David's suggestion dividing the udp_media.c as
an separate module.
Regards,
Ying
next prev parent reply other threads:[~2015-03-23 3:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 15:13 [PATCH] tipc: fix build issue when building without IPv6 Marcelo Ricardo Leitner
2015-03-19 19:04 ` David Miller
2015-03-19 19:16 ` Marcelo Ricardo Leitner
2015-03-19 19:47 ` [PATCH v2] " Marcelo Ricardo Leitner
2015-03-19 20:06 ` David Miller
2015-03-20 2:09 ` Ying Xue
2015-03-20 12:35 ` Marcelo
2015-03-23 3:00 ` Ying Xue [this message]
2015-03-23 11:33 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550F81C1.4020701@windriver.com \
--to=ying.xue@windriver$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=erik.hugne@ericsson$(echo .)com \
--cc=jon.maloy@ericsson$(echo .)com \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richard.alpe@ericsson$(echo .)com \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox