Subject: Re: [PATCH net-next V2 17/23] ptp: stmmac: convert to the 64 bit get/set time methods.

From: Giuseppe CAVALLARO <[email-masked]>
Date: Mon, 23 Mar 2015 16:35:06 +0100

On 3/21/2015 10:39 PM, Richard Cochran wrote:
> This device stores the number of seconds in a 32 bit register.  So
> more work is needed on this driver before the year 2038 comes around.
>
> Compile tested only.

I cannot perform tests on my side, unfortunately. I have no setup at
this moment. Added Rayagond on copy too

Peppe

>
> Signed-off-by: Richard Cochran <[email-masked]>
> ---
>   drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c |    8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> index c5ee79d8..172f318 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> @@ -105,7 +105,7 @@ static int stmmac_adjust_time(struct ptp_clock_info *ptp, s64 delta)
>    * Description: this function will read the current time from the
>    * hardware clock and store it in @ts.
>    */
> -static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec *ts)
> +static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec64 *ts)
>   {
>   	struct stmmac_priv *priv =
>   	    container_of(ptp, struct stmmac_priv, ptp_clock_ops);
> @@ -135,7 +135,7 @@ static int stmmac_get_time(struct ptp_clock_info *ptp, struct timespec *ts)
>    * hardware clock.
>    */
>   static int stmmac_set_time(struct ptp_clock_info *ptp,
> -			   const struct timespec *ts)
> +			   const struct timespec64 *ts)
>   {
>   	struct stmmac_priv *priv =
>   	    container_of(ptp, struct stmmac_priv, ptp_clock_ops);
> @@ -168,8 +168,8 @@ static struct ptp_clock_info stmmac_ptp_clock_ops = {
>   	.pps = 0,
>   	.adjfreq = stmmac_adjust_freq,
>   	.adjtime = stmmac_adjust_time,
> -	.gettime = stmmac_get_time,
> -	.settime = stmmac_set_time,
> +	.gettime64 = stmmac_get_time,
> +	.settime64 = stmmac_set_time,
>   	.enable = stmmac_enable,
>   };
>
>