Subject: Re: [PATCH] ucc_geth: Intialize link state to down before register_netdev

From: Lino Sanfilippo <[email-masked]>
Date: Tue, 24 Mar 2015 20:30:00 +0100

On 24.03.2015 19:51, [email-masked] wrote:
> ucc_geth was indicating link up after a port is administratively enabled 
> even
> when nothing is plugged in.  This causes user-space tools to see a 
> spurious link
> up the first time after boot.
> 
> Signed-off-by: Cliff Clark <[email-masked]>
> ---
>  drivers/net/ethernet/freescale/ucc_geth.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/ucc_geth.c 
> b/drivers/net/ethernet/freescale/ucc_geth.c
> index 357e8b57..56b774d 100644
> --- a/drivers/net/ethernet/freescale/ucc_geth.c
> +++ b/drivers/net/ethernet/freescale/ucc_geth.c
> @@ -3893,6 +3893,9 @@ static int ucc_geth_probe(struct platform_device* 
> ofdev)
>         ugeth->phy_interface = phy_interface;
>         ugeth->max_speed = max_speed;
>  
> +       /* Carrier starts down, phylib will bring it up */
> +       netif_carrier_off(dev);
> +
>         err = register_netdev(dev);
>         if (err) {
>                 if (netif_msg_probe(ugeth))

The commit message is still messy. checkpatch also complaints about
spaces at the beginning of a line.

Regards,
Lino