From: Florian Fainelli <f.fainelli@gmail•com>
To: Petri Gynther <pgynther@google•com>, netdev@vger•kernel.org
Cc: davem@davemloft•net, jaedon.shin@gmail•com
Subject: Re: [PATCH net-next 4/7] net: bcmgenet: tweak init_umac()
Date: Wed, 25 Mar 2015 15:23:41 -0700 [thread overview]
Message-ID: <5513356D.1000302@gmail.com> (raw)
In-Reply-To: <20150325193513.08B462201FB@puck.mtv.corp.google.com>
On 25/03/15 12:35, Petri Gynther wrote:
> Use more meaningful variable names int0_enable and int1_enable when
> enabling bcmgenet interrupts.
>
> For Rx default queue interrupts, use:
> UMAC_IRQ_RXDMA_BDONE | UMAC_IRQ_RXDMA_PDONE
>
> For Tx default queue interrupts, use:
> UMAC_IRQ_TXDMA_BDONE | UMAC_IRQ_TXDMA_PDONE
Can we define a constant for these two, kind of like what I did earlier
with UMAC_IRQ_RXDMA_MASK and UMAC_IRQ_TXDMA_MASK?
Does not need to happen now, but it could make the code clearer.
>
> Signed-off-by: Petri Gynther <pgynther@google•com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail•com>
--
Florian
next prev parent reply other threads:[~2015-03-25 22:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 19:35 [PATCH net-next 4/7] net: bcmgenet: tweak init_umac() Petri Gynther
2015-03-25 22:23 ` Florian Fainelli [this message]
2015-03-26 17:50 ` Petri Gynther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5513356D.1000302@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jaedon.shin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pgynther@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox