Subject: Re: [PATCH] net: phy: at803x: simplify using devm_gpiod_get_optional and its 4th argument

From: Alexandre Courbot <[email-masked]>
Date: Sat, 28 Mar 2015 13:52:41 +0900

On 03/28/2015 04:25 AM, Uwe Kleine-König wrote:
> Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> parameter that allows to specify direction and initial value for output.
> Moreover use devm_gpiod_get_index_optional instead of ignoring all
> errors returned by devm_gpiod_get. Simplify accordingly.
>
> The result is more strict error handling which is good.

Reviewed-by: Alexandre Courbot <[email-masked]>

>
> Signed-off-by: Uwe Kleine-König <[email-masked]>
> ---
>   drivers/net/phy/at803x.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index f80e19ac6704..87dd633a8d1f 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -197,15 +197,12 @@ static int at803x_probe(struct phy_device *phydev)
>   	if (!priv)
>   		return -ENOMEM;
>
> -	priv->gpiod_reset = devm_gpiod_get(dev, "reset");
> -	if (IS_ERR(priv->gpiod_reset))
> -		priv->gpiod_reset = NULL;
> -	else
> -		gpiod_direction_output(priv->gpiod_reset, 1);
> +	priv->gpiod_reset = devm_gpiod_get_optional(dev, "reset",
> +						    GPIOD_OUT_HIGH);
>
>   	phydev->priv = priv;
>
> -	return 0;
> +	return IS_ERR(priv->gpiod_reset);
>   }
>
>   static int at803x_config_init(struct phy_device *phydev)
>
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------