Subject: Re: [PATCH net-next 1/2] net: neighbour: Add mcast_resolicit to configure the number of multicast resolicitations in PROBE state.

From: YOSHIFUJI Hideaki <[email-masked]>
Date: Mon, 30 Mar 2015 08:49:44 +0900

Hi,

Ulf Samuelsson wrote:
> Should not this patch add modifications to "kernel/sysctl_binary.c" and
> "include/linux/sysctl.h" as well?

We do not add binary sysctls any more.

> mcast_probes and ucast_probes are initialized in arp.c and ndisc.c.
> Should we not initialize also mcast_reprobes, even if it is zero?

We could, but unneccessary.

> There are some statistics printout in net/core/neighbour.c.
> They handle mcast_solicit and ucast_solicit.
> 
> Are they unneccessary for mcast_resolicit?

Not neccessary.
Hint: What are those for?  Where/How do we increment those counters?

-- 
Hideaki Yoshifuji <[email-masked]>
Technical Division, MIRACLE LINUX CORPORATION