From: Jamal Hadi Salim <jhs@mojatatu•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: netdev@vger•kernel.org, davem@davemloft•net, tgraf@suug•ch,
jesse@nicira•com
Subject: Re: [patch net-next] tc: introduce OpenFlow classifier
Date: Mon, 30 Mar 2015 07:10:24 -0400 [thread overview]
Message-ID: <55192F20.3030508@mojatatu.com> (raw)
In-Reply-To: <20150330062632.GB2045@nanopsycho.orion>
On 03/30/15 02:26, Jiri Pirko wrote:
> Mon, Mar 30, 2015 at 02:39:31AM CEST, jhs@mojatatu•com wrote:
>> Could you have got rid of "type" above given we always have
>> a "proto" field in tc that is checked at the core?
>
> Sure it is possible. But I try to stick with the names used in OpenFlof
> documentation.
>
Ok, thats fine. Safer to stick with the spec.
>> Was there something else that was intended to go into that tp union?
>
> Following fields are missing:
>
> OXM_OF_SCTP_SRC
> OXM_OF_SCTP_DST
> OXM_OF_ICMPV4_TYPE
> OXM_OF_ICMPV4_CODE
>
It just looked strange to have a union with only one member.
>> General comments:
>> so what happens if someone adds a new field? It sounds to me like
>> given it is tied to datapath match it will never be backward compatible
>> (i.e think old tc, new kernel vs new tc, old kernel)
>
>
> Well if kernel does not understand the new field, it will simply ignore
> it.
>
More like user expectation may be different. I suppose they could query
the kernel and find that their field was not set.
BTW, another micro optimization:
You could pre-compute the user passed key/mask result per field and
in the fast path use that instead of doing f->match.key & f->match.mask
cheers,
jamal
next prev parent reply other threads:[~2015-03-30 11:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 12:53 [patch net-next] tc: introduce OpenFlow classifier Jiri Pirko
2015-03-26 12:55 ` [patch iproute2/net-next] tc: add support for " Jiri Pirko
2015-03-26 13:25 ` [patch net-next] tc: introduce " Thomas Graf
2015-03-26 14:22 ` Jiri Pirko
2015-03-26 14:23 ` Hannes Frederic Sowa
2015-03-26 15:29 ` Jiri Pirko
2015-03-26 20:39 ` Hannes Frederic Sowa
2015-03-26 20:51 ` Daniel Borkmann
2015-03-27 6:07 ` Jiri Pirko
2015-03-27 11:44 ` Thomas Graf
2015-03-27 12:28 ` Jiri Pirko
2015-03-27 12:36 ` Thomas Graf
2015-03-27 12:45 ` Jiri Pirko
2015-03-27 12:49 ` Thomas Graf
2015-03-30 0:45 ` Jamal Hadi Salim
2015-03-30 0:39 ` Jamal Hadi Salim
2015-03-30 6:26 ` Jiri Pirko
2015-03-30 11:10 ` Jamal Hadi Salim [this message]
2015-03-30 12:18 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55192F20.3030508@mojatatu.com \
--to=jhs@mojatatu$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jesse@nicira$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox